Use tabs in package(-lock).json#3098
Merged
RunDevelopment merged 1 commit intoPrismJS:masterfrom Sep 27, 2021
valtlai:tabs
Merged
Use tabs in package(-lock).json#3098RunDevelopment merged 1 commit intoPrismJS:masterfrom valtlai:tabs
RunDevelopment merged 1 commit intoPrismJS:masterfrom
valtlai:tabs
Conversation
Member
|
Thank you for the PR @valtlai! Both of these files are generated and managed by npm. We can't choose the indentation because every For this reason, I will reject this PR. |
Contributor
Author
|
That’s not true: npm does maintain the indentation style, i.e. running |
Member
|
Oh, I found an old issue where people were angry that it didn't. They must have changed it since then. |
Contributor
Author
|
Yeah, I’ve probably used npm too little time since I didn’t know this hasn’t always worked like today. 😄 |
RunDevelopment
approved these changes
Sep 27, 2021
Member
|
Thank you for contributing @valtlai! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more consistent with the most of the code base, and npm will preserve the indentation style.