Normalize Whitespace: Removed unnecessary checks#3017
Merged
RunDevelopment merged 1 commit intoPrismJS:masterfrom Aug 2, 2021
Merged
Normalize Whitespace: Removed unnecessary checks#3017RunDevelopment merged 1 commit intoPrismJS:masterfrom
RunDevelopment merged 1 commit intoPrismJS:masterfrom
Conversation
mAAdhaTTah
approved these changes
Aug 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #3016.
The
typeof document === 'undefined'was unnecessary. The plugin does interact with the DOM but only in thebefore-sanity-checkhook which is run insidehighlightElementwhich is given a DOM element. So the plugin only tries to interact with the DOM if it is given a DOM element. Therefore, the check is unnecessary.I also removed a duplicate
typeof Prism === 'undefined'check. No idea why that was there.