Skip to content

Add support for @propertyWrapper, @MainActor, @globalActor#3009

Merged
RunDevelopment merged 7 commits intoPrismJS:masterfrom
AvdLee:master
Jul 26, 2021
Merged

Add support for @propertyWrapper, @MainActor, @globalActor#3009
RunDevelopment merged 7 commits intoPrismJS:masterfrom
AvdLee:master

Conversation

@AvdLee
Copy link
Copy Markdown
Contributor

@AvdLee AvdLee commented Jul 24, 2021

New types that didn't exist in Prism yet, but we need them! 🎉

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 24, 2021 •
edited
Loading

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +20 B (+1.9%).

Details
file master pull size diff % diff
components/prism-swift.min.js 1.04 KB 1.06 KB +20 B +1.9%

Generated by 🚫 dangerJS against 09bf331

RunDevelopment
RunDevelopment requested changes Jul 24, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit. Apart from that it's gtg. Thank you @AvdLee!

@RunDevelopment
Copy link
Copy Markdown
Member

RunDevelopment commented Jul 24, 2021

Also, please use backticks around @propertyWrapper (and others) in commit messages, comments, and titles. Otherwise, GitHub will ping these people. Let's try to not annoy them :)

@AvdLee @RunDevelopment
Update components/prism-swift.js
8a5e993 
Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
@AvdLee
Copy link
Copy Markdown
Contributor Author

AvdLee commented Jul 26, 2021

Also, please use backticks around @propertyWrapper (and others) in commit messages, comments, and titles. Otherwise, GitHub will ping these people. Let's try to not annoy them :)

Oh, oops! didn't think about that!

@RunDevelopment
Copy link
Copy Markdown
Member

RunDevelopment commented Jul 26, 2021

The build still fails. Could you please rebuild Prism?

@AvdLee
Copy link
Copy Markdown
Contributor Author

AvdLee commented Jul 26, 2021

The build still fails. Could you please rebuild Prism?

I've never done that before, my previous PR succeeded as well w/o rebuilding Prism 🤔
Is there any guidance for this? I'm not really experienced in deploying such packages

@RunDevelopment
Copy link
Copy Markdown
Member

RunDevelopment commented Jul 26, 2021

Just run npm ci && npm run build and commit the changes.

@AvdLee
Copy link
Copy Markdown
Contributor Author

AvdLee commented Jul 26, 2021

Thanks, that was actually easy. Pushed the changes, let's see if CI is happy now!

@RunDevelopment RunDevelopment merged commit ce5e0f0 into PrismJS:master Jul 26, 2021
@RunDevelopment
Copy link
Copy Markdown
Member

RunDevelopment commented Jul 26, 2021

Thank you for contributing @AvdLee!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RunDevelopment RunDevelopment RunDevelopment requested changes

Assignees

No one assigned

Labels

enhancement language-definitions needs changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AvdLee @RunDevelopment