Skip to content

Xojo-Language: Fixed wrong Pattern for "REM" Comments#2823

Merged
RunDevelopment merged 2 commits intoPrismJS:masterfrom
XojoGermany:master
Mar 22, 2021
Merged

Xojo-Language: Fixed wrong Pattern for "REM" Comments#2823
RunDevelopment merged 2 commits intoPrismJS:masterfrom
XojoGermany:master

Conversation

@XojoGermany
Copy link
Copy Markdown
Contributor

REM was incorrectly identified as a keyword. This has been fixed. REM is now recognized as a comment.

REM was incorrectly identified as a keyword. This has been fixed. REM is now recognized as a comment.
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 21, 2021

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of -14 B (-1.9%).

Details
file master pull size diff % diff
components/prism-xojo.min.js 737 B 723 B -14 B -1.9%

Generated by 🚫 dangerJS against e5736d0

@XojoGermany
Copy link
Copy Markdown
Contributor Author

XojoGermany commented Mar 21, 2021

Oh man, why is it so complicated with the updates? What exactly needs to be done now to fix the error message?
Xojo

@RunDevelopment
Copy link
Copy Markdown
Member

Oh man, why is it so complicated with the updates? What exactly needs to be done now to fix the error message?

Well, I could say: "please read the error message." The error message says:

  1974 passing (2s)
  1 failing

  1) Testing language 'xojo'
       – should pass test case 'comment_feature':

      AssertionError: Checks for comments and remarks.

Actual Token Stream:
-----------------------------------------
[
    ["comment", "' Foobar"],
    ["comment", "// Foobar"],
    ["comment", "Rem Foobar"]
]
-----------------------------------------
File: /home/runner/work/prism/prism/tests/languages/xojo/comment_feature.test:4:14

The most important part of the message is that it tells you the file you have to update. It's tests/languages/xojo/comment_feature.test.

But I really get you. This should be a lot easier.
And it will be after #2809 gets merged. I made this after your first PR specifically to make the whole process easier for contributors that just want to make a small change. After my PR gets merged, you just have to run npm run test:languages -- --update and everything will just work.

@RunDevelopment RunDevelopment merged commit ebbbfd4 into PrismJS:master Mar 22, 2021
@RunDevelopment
Copy link
Copy Markdown
Member

Thank you for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants