Conversation
RunDevelopment
left a comment
There was a problem hiding this comment.
Thank you for the PR @dmitry-surkov!
I left you a few comments but we also need to talk about punctuation and operators. Right now, you defined a lot of patterns. The problem with that is that our themes do not recognize these token names, leaving them unhighlighted. On your website, you solved this by modifying your themes but this a lot harder on our side.
Would it be possible to combine these patterns into an operator and a punctuation token like we do in other languages? If more granular highlighting is needed, I suggest doing it like this:
{
'operator': [
{
pattern: /=/,
alias: 'equals'
},
// rest
/[-+*/]/
]
}0247dfa to
784ad01
Compare
Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
c776878 to
66037d9
Compare
|
@RunDevelopment, seems I have resolved all the issues. Do you see any other issues that prevent this PR from merge? Btw, I have also merged all changes from the |
|
Thank you for contributing @dmitry-surkov! |
Add support for Nevod language used for pattern-based text search.