Fix INI#2779
Merged
RunDevelopment merged 3 commits intoPrismJS:masterfrom Mar 2, 2021
edukisto:topic-2775
Merged
Conversation
Contributor
Author
|
I’ve also replaced |
RunDevelopment
requested changes
Mar 1, 2021
Member
RunDevelopment
left a comment
There was a problem hiding this comment.
Great work @edukisto!
I have a few questions and suggestions.
Also, please add a comment with a link to your detailed explanation of the differences in INI parsers. And please also mention that Prism's INI implements the Win32 behaviour. This will make it easier for others to understand the code.
RunDevelopment
approved these changes
Mar 2, 2021
Member
|
Thank you for contributing @edukisto! |
Contributor
Author
|
Thank you for your help and guidance, @RunDevelopment! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for being late! This PR resolves #2775. I’ve made the module mimic the behavior of Win32 API.