[PHP] Add support for enum in class-name_feature context#2752
Merged
RunDevelopment merged 1 commit intoPrismJS:masterfrom Feb 18, 2021
Ayesh:php/enum
Merged
[PHP] Add support for enum in class-name_feature context#2752RunDevelopment merged 1 commit intoPrismJS:masterfrom Ayesh:php/enum
enum in class-name_feature context#2752RunDevelopment merged 1 commit intoPrismJS:masterfrom
Ayesh:php/enum
Conversation
[PHP 8.1 adds Enum support](https://php.watch/versions/8.1/enums#enum-syntax). This PR updates the class-like structure matching regex and its tests to accommodate the new `enum` structures. Related: #2731
Contributor
Author
|
I will keep this PR as a draft until the voting period for Enum proposal ends. It is very likely to pass, but I'd like to wait for the final vote off. Thank you. |
RunDevelopment
approved these changes
Feb 6, 2021
Member
RunDevelopment
left a comment
There was a problem hiding this comment.
LGTM;
Looking forward to having this in Prism once the draft is through.
Contributor
Author
|
RFC vote ended with 44:7 in favor. PHP 8.1 will have Enums 🎉🎊. |
RunDevelopment
approved these changes
Feb 18, 2021
Member
|
Thank you for contributing @Ayesh! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.1 adds Enum support. This PR updates the class-like structure matching regex and its tests to accommodate the new
enumstructures.Related: #2731