Add support for PSL, PATROL Scripting Language (#2735)#2739
Merged
RunDevelopment merged 4 commits intoPrismJS:masterfrom Jan 27, 2021
sentrysoftware:feature/issue-2735-psl
Merged
Add support for PSL, PATROL Scripting Language (#2735)#2739RunDevelopment merged 4 commits intoPrismJS:masterfrom sentrysoftware:feature/issue-2735-psl
RunDevelopment merged 4 commits intoPrismJS:masterfrom
sentrysoftware:feature/issue-2735-psl
Conversation
JS File Size Changes (gzipped)A total of 2 files have changed, with a combined diff of +1.65 KB (+75.9%). Details
|
Contributor
Author
|
This resolves #2735 |
RunDevelopment
requested changes
Jan 26, 2021
Member
RunDevelopment
left a comment
There was a problem hiding this comment.
Thank you for the PR @bertysentry!
Contributor
Author
|
Thank you @RunDevelopment for the thorough and awesomely helpful review! I really appreciate it. I will take your suggestions into account and push the result later today. |
* coloring of user-defined functions * better operator handling * improved tests
Contributor
Author
|
@RunDevelopment Thank you again for the help on this! Code has been updated according to your suggestions. |
Contributor
Author
|
@RunDevelopment All good? Again, thank you for the tremendous help! :-) |
RunDevelopment
approved these changes
Jan 27, 2021
Member
|
Thank you for contributing @bertysentry! |
Contributor
Author
|
Thank you @RunDevelopment for your reactivity and your detailed and helpful review! |
This was referenced Jun 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for PSL language, the scripting language used to write modules on the PATROL Agent (BMC Software).
All tests pass :-)