Add support for V langauge#2687
Merged
RunDevelopment merged 7 commits intoPrismJS:masterfrom Jan 8, 2021
taggon:add-v-support
Merged
Add support for V langauge#2687RunDevelopment merged 7 commits intoPrismJS:masterfrom taggon:add-v-support
RunDevelopment merged 7 commits intoPrismJS:masterfrom
taggon:add-v-support
Conversation
JS File Size Changes (gzipped)A total of 2 files have changed, with a combined diff of +969 B (+45.1%). Details
|
RunDevelopment
requested changes
Jan 2, 2021
Member
RunDevelopment
left a comment
There was a problem hiding this comment.
Thank you for making this PR @taggon!
I left you a few comments. Also, directives (e.g. #flag linux -lsdl2, #include "sqlite3.h") and nested multiline comments are not supported. Please add them.
Apart from that, very solid work. Thank you!
Contributor
Author
|
@RunDevelopment Thanks. I fixed all the problems you mentioned and also add support for directives(such as |
RunDevelopment
requested changes
Jan 7, 2021
Member
RunDevelopment
left a comment
There was a problem hiding this comment.
Thank you for your work!
I'm sorry but one of my suggestions contained faulty code. My comment contains more information and a fix.
RunDevelopment
approved these changes
Jan 8, 2021
Member
|
Thank you for contributing @taggon! |
This was referenced Jun 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the V langauge.