Skip to content

Apache: Update directive-flag to match '='#2612

Merged
RunDevelopment merged 2 commits intoPrismJS:masterfrom
danielmorell:master
Oct 26, 2020
Merged

Apache: Update directive-flag to match '='#2612
RunDevelopment merged 2 commits intoPrismJS:masterfrom
danielmorell:master

Conversation

@danielmorell
Copy link
Contributor

This PR fixes an bug where directive flags are not matched consistently.

Apache configuration flags mostly follow this format...

[NC]

L,R,NC]

However, they sometimes use the following format...

[L,R=301,NC]

This simply adjusts the regex to include =.

@RunDevelopment
Copy link
Member

Thank you for the PR @danielmorell!

Please add your example to this test file. You can find more information about tests here.

@danielmorell
Copy link
Contributor Author

@RunDevelopment Done.

@RunDevelopment RunDevelopment merged commit 00bf00e into PrismJS:master Oct 26, 2020
@RunDevelopment
Copy link
Member

Thank you for contributing @danielmorell!

This was referenced Mar 6, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants