Remove Julia constants that are not exported by default#2601
Merged
RunDevelopment merged 2 commits intoPrismJS:masterfrom Oct 23, 2020
Merged
Remove Julia constants that are not exported by default#2601RunDevelopment merged 2 commits intoPrismJS:masterfrom
RunDevelopment merged 2 commits intoPrismJS:masterfrom
Conversation
Member
|
Thank for the pull request @knuesel! The change seems reasonable. I guess you left The make the build pass, you also have to run |
Contributor
Author
|
@RunDevelopment sorry for missing that, should be fixed now. I left |
RunDevelopment
approved these changes
Oct 23, 2020
This was referenced Mar 6, 2021
This was referenced Mar 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removed a few unexported constants for Julia. These constants are defined in the
Base.MathConstantsmodule, but they are unexported. So it should not be assumed that these names (without a module prefix) represent constants in Julia code.To illustrate, I ended up here because I was wondering why the
elooks funny on https://docs.julialang.org/en/v1/base/arrays/#Base.hvcat . It turns out PrismJS treatseas a Julia constant. This is wrong: by default, someone typingein Julia will get the errore not defined).