Added more plugin tests#1969

Merged

RunDevelopment merged 18 commits intoPrismJS:masterfrom

RunDevelopment:more-plugin-tests

Oct 5, 2021

Member

RunDevelopment commented Jul 11, 2019 •

edited

Loading

This adds more plugin tests and a new way to create Prism instances inside a JSDOM VM.

It also fixes that Copy to Clipboard did not update the copied text if the text of the code element changed.
This can technically be seen as a fix for #1965.

Also, I just named the tests files basic-functionality for lack of a better name. Suggestions for a better pattern are very welcome.


          Added more plugin tests

be610ef

RunDevelopment added enhancement plugins needs review labels

RunDevelopment mentioned this pull request

Add tests for all plugins #1970

Open

20 tasks

RunDevelopment added 5 commits

July 11, 2019 16:08


          Minor improvements

8d58e43


          Added Show language test

4fdec00


          Unescaped markup tests + refactoring

ae16e58


          Proper DOM closing

b401060


          Better error messages

mAAdhaTTah reviewed

View reviewed changes

plugins/copy-to-clipboard/prism-copy-to-clipboard.js Outdated Show resolved Hide resolved

mAAdhaTTah reviewed

View reviewed changes

tests/helper/prism-loader.js Outdated Show resolved Hide resolved

mAAdhaTTah reviewed

View reviewed changes

tests/plugins/copy-to-clipboard/basic-functionality.js Outdated Show resolved Hide resolved

mAAdhaTTah reviewed

View reviewed changes

tests/plugins/copy-to-clipboard/basic-functionality.js Outdated Show resolved Hide resolved

mAAdhaTTah reviewed

View reviewed changes

tests/plugins/custom-class/basic-functionality.js Outdated Show resolved Hide resolved

RunDevelopment mentioned this pull request

File Highlight & JSONP Highlight update #1974

Merged

RunDevelopment added 6 commits

October 1, 2021 23:12


          Merge branch 'master' into more-plugin-tests

216b834


          New usePrismDom util function

1fab13f


          Fixed copy to clipboard test

20dd51a


          Make createUtil requrie less

e248e69


          Consistently use new util function everywhere

f5daca7


          Fixed failing tests

a87151a

github-actions bot commented Oct 1, 2021 •

edited

Loading

No JS Changes

Generated by 🚫 dangerJS against df8ee50

RunDevelopment added 2 commits

October 2, 2021 00:46


          Fixed linting error

9f37f83


          Updated JSDom

f9d0c06

Member Author

RunDevelopment commented Oct 1, 2021 •

edited

Loading

Shit, I forgot about this.

I resolved the merge conflicts and addressed all review comments.

I fixed the usage of after by adding a util function called createScopedPrismDom. The idea is that this function creates a Prism DOM and registers a cleanup function for the DOM. It's called reusable because the DOM instance is intended to be used by multiple it tests.

I also updated JSDom. JSDom 16 added support for createRange which drastically simplifies Keep Markup tests.

RunDevelopment added 3 commits

October 4, 2021 17:26


          Removed main function to createScopedPrismDom

4d1d70e


          Merge branch 'master' into more-plugin-tests

d7846fa


          Fixed package lock

1668ed7

RunDevelopment requested a review from mAAdhaTTah

October 4, 2021 15:28


          Merge branch 'master' into more-plugin-tests

df8ee50

Member Author

RunDevelopment commented Oct 5, 2021

I will merge this now because I want to implement update #2640 and this PR will cause conflicts.

RunDevelopment merged commit a394a14 into PrismJS:master

RunDevelopment deleted the more-plugin-tests branch

October 5, 2021 20:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement needs review plugins