Skip to content

Toolbar: Fixed overflow issue#1966

Merged
RunDevelopment merged 4 commits intoPrismJS:masterfrom
RunDevelopment:toolbar-overflow-fix
Sep 3, 2019
Merged

Toolbar: Fixed overflow issue#1966
RunDevelopment merged 4 commits intoPrismJS:masterfrom
RunDevelopment:toolbar-overflow-fix

Conversation

@RunDevelopment
Copy link
Copy Markdown
Member

This fixed the overflow issue of Toolbar with Prism's Theme selection. The fixed bug can be seen on the plugin pages of Toolbar, Copy to Clipboard, and Show language.

I'm aware that the artificial transfer of the pre margin to the wrapper isn't an elegant solution, so I'm open for suggestions.

@RunDevelopment
Copy link
Copy Markdown
Member Author

Alright, I changed the implementation.
The "margin transfer" code is now in scripts/code.js. It'll add a hook to get every highlighted element and applies the fix to elements which have been given a toolbar.

Copy link
Copy Markdown
Member

@mAAdhaTTah mAAdhaTTah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants