Skip to content

Allow template vars override in hook actionFrontControllerSetVariables#14049

Merged
matks merged 1 commit intoPrestaShop:developfrom
Matt75:hookActionFrontControllerSetVariables
Jul 2, 2019
Merged

Allow template vars override in hook actionFrontControllerSetVariables#14049
matks merged 1 commit intoPrestaShop:developfrom
Matt75:hookActionFrontControllerSetVariables

Conversation

@Matt75
Copy link
Copy Markdown
Contributor

@Matt75 Matt75 commented Jun 2, 2019 •
edited by matks
Loading

Questions Answers
Branch? develop
Description? Allow template vars override in hook actionFrontControllerSetVariables
Type? improvement
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Please see https://github.com/Matt75/displayshoplogobylang which requires this hook modification to work properly

This change is Reviewable

@Matt75 Matt75 requested a review from a team as a code owner June 2, 2019 19:49
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Jun 2, 2019
@matks
Copy link
Copy Markdown
Contributor

matks commented Jun 3, 2019

Does it solve partially needs expressed in #13462 or #11125 ?

@Matt75
Copy link
Copy Markdown
Contributor Author

Matt75 commented Jun 3, 2019 •
edited
Loading

#13462 is related to Twig, this is for FO who still use Smarty so I don’t think.

#11125 is related to Presenters, here it’s about template vars in FrontController class. I think it’s better to add another hook for Presenters. Maybe I will need it for wishlist module ?

But seems to be similar needs.

@matks matks added the Waiting for QA Status: action required, waiting for test feedback label Jun 14, 2019
@matks
Copy link
Copy Markdown
Contributor

matks commented Jun 14, 2019

Note: after merge, needs to be added to hook list on devdocs

As it is a FO hook, it does not need to be added to hook.xml nor in the SQL upgrade, does it ? 🤔

@PierreRambaud PierreRambaud added this to the 1.7.7.0 milestone Jun 14, 2019
@sarahdib sarahdib added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jun 27, 2019
@matks
Copy link
Copy Markdown
Contributor

matks commented Jul 2, 2019

Thank you @Matt75

@matks matks merged commit 2dfb42b into PrestaShop:develop Jul 2, 2019
@matks
Copy link
Copy Markdown
Contributor

matks commented Jul 2, 2019

Note: after merge, needs to be added to hook list on devdocs

As it is a FO hook, it does not need to be added to hook.xml nor in the SQL upgrade, does it ? 🤔

ping @Quetzacoalt91 @PierreRambaud
Do we need to update hook.xml and SQL upgrade for FO (= legacy) hooks, or is it only for Symfony hooks ?

@Quetzacoalt91
Copy link
Copy Markdown
Member

Quetzacoalt91 commented Jul 2, 2019

You may want to add it into the file hook.xml if you want to provide details about this hook. That's not a mandatory step though.

@Matt75 Matt75 deleted the hookActionFrontControllerSetVariables branch September 24, 2019 14:53
@jf-viguier
Copy link
Copy Markdown
Contributor

jf-viguier commented Dec 23, 2019

Yes, please add a hook for Presenters overriding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@PierreRambaud PierreRambaud PierreRambaud approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

develop Branch Improvement Type: Improvement QA ✔️ Status: check done, code approved

Projects

None yet

Milestone

1.7.7.0

Development

Successfully merging this pull request may close these issues.

7 participants

@Matt75 @matks @Quetzacoalt91 @jf-viguier @PierreRambaud @sarahdib @prestonBot