Skip to content
This repository was archived by the owner on Apr 24, 2020. It is now read-only.

similar to PR #472, fixing for awesome font mappings#599

Merged
bhilburn merged 1 commit intoPowerlevel9k:nextfrom
pfrybar:awesome-font-mapping
Aug 27, 2017
Merged

similar to PR #472, fixing for awesome font mappings#599
bhilburn merged 1 commit intoPowerlevel9k:nextfrom
pfrybar:awesome-font-mapping

Conversation

@pfrybar
Copy link
Contributor

@pfrybar pfrybar commented Aug 12, 2017

This is basically #472 but with the requested changes. I spent some time today getting this working for me and thought I would share my results. This creates a new icon set called awesome-mapped-fontconfig so it won't break for any existing users. This relies on the user sourcing the font mapping files in their shell startup scripts, as recommended by: https://github.com/gabrielelana/awesome-terminal-fonts#font-maps. It does a simple check to ensure the fonts maps were sourced, and logs a warning if they weren't.

@bhilburn bhilburn merged commit 0f58a49 into Powerlevel9k:next Aug 27, 2017
@bhilburn
Copy link
Member

Nice work, @pfrybar! This is exactly what we needed. I appreciate you finishing up the work from #472 and then testing it out.

I know this took a while - many months since @V1rgul first put together the commits that started the effort. Fonts are painful, but I think we ended up with the best solution, here.

I really want to thank @V1rgul for pushing the idea and providing guidance, @gabrielelana for updating the AwesomeFont project docs based on our needs, and @dritter for the review feedback in the previous two PRs.

Great PR, @pfrybar - especially for a first contribution! Welcome to P9k!

Thanks, all! And, obviously, please file bugs / new PRs if you see issues =)

@bhilburn
Copy link
Member

(By the way, I'll update the wiki to tell users to use awesome-mapped-fontconfig once we make our next release, which I would like to do relatively quickly behind v0.6.4)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants