update fontconfig icons, using awesome-terminal-fonts maps#385
update fontconfig icons, using awesome-terminal-fonts maps#385V1rgul wants to merge 6 commits intoPowerlevel9k:nextfrom
Conversation
|
Thanks so much for making this PR, @V1rgul! I know you made it a couple of weeks ago as a result of our discussion in #382. While this change fixes the code-point problem for the awesome-fontconfig, it actually further breaks other forms of awesome fontconfigs (baked-in fonts) that have different code-points that the patch. What I'm planning to do at this point is merge this PR in and create a new font-group option for the baked-in option. This PR will get pushed up to Thanks so much for putting in the effort to make this PR, and then keeping up with it over the last couple weeks. I really appreciate it =) |
|
Haven't dropped this, by the way. Will be going in, in a slightly different form, soon... |
|
@V1rgul - I just pushed some changes to This relies on the formal installation of Awesome Fontconfig in ~/.fonts, but I only see that as the recommended installation method on Linux. Does this work on OSX? |
|
Is it possible to set the path to the mapping files as an overridable variable(s)? I agree that's the safest setting as detailed by the awesome fonts README, but I'm on Linux and I have opted to install an awesome-terminal fonts package which will have a different mapping file path. |
|
@rhabbachi @bhilburn I fixed the conflicts and implemented a configurable fontawesome path ;) |
|
@bhilburn does it need anything more before merging ? |
|
Sorry for being AWOL on this, @V1rgul. I decided to wait until after The other primary thing I'm concerned about is this breaking other font types using the If this is the "one true way" to do code points with "Font Awesome"-based fonts, then perhaps it's time to break out "Source Code Pro" and other built-in fonts into their own font option. I certainly want to make the use of the 'awesome-*' fonts as easy as possible. What are your thoughts on this? |
|
@bhilburn I am on @V1rgul 's side.
I agree, maybe we need a new option for "SourceCode Pro". But for |
|
Just a note that I haven't forgotten about this. Just haven't finished integrating & testing =) |
|
Any news for this? Been using it for a while now and works great for me. |
|
@rhabbachi - We are working on getting it merged in #472 =) @V1rgul - I'm actually going to close this PR since all of your commits are in #472, anyway. |
fixes #382