-
Notifications
You must be signed in to change notification settings - Fork 161
Ensure NULL string value is written as quoted string in YAML #759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sdwheeler
approved these changes
Jul 2, 2025
Collaborator
sdwheeler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request introduces a new feature to handle
NULLvalues in YAML serialization by quoting them, along with corresponding updates to tests and serializers. The most important changes include adding a custom event emitter for quotingNULLstrings, updating the YAML serializer to use this emitter, and adding tests to validate the new behavior.YAML Serialization Enhancements:
NULL: Added a new classQuotedNullStringEventEmitterthat ensuresNULLvalues are serialized as'NULL'in YAML. This class overrides theEmitmethod to handleNULLstrings explicitly. (src/YamlWriter/QuotedNullStringEventEmitter.cs)YamlUtilsclass to use the newQuotedNullStringEventEmitterin the YAML serializer configuration. (src/Common/YamlUtils.cs)Testing Updates:
NULLHandling: Added a test case inExport-YamlCommandHelpto verify thatNULLvalues are correctly quoted as'NULL'in the serialized YAML output. (test/Pester/ExportYamlCommandHelp.Tests.ps1)MeasurePlatyPSMarkdowntests to reflect the addition of new test assets. (test/Pester/MeasurePlatyPSMarkdown.Tests.ps1)PR Context
Fixes #758