Fix issues with the Win32 implementation of the POSIX dynamic library API#379
Merged
Merged
Conversation
|
|
Merged
manojampalam
suggested changes
Mar 25, 2019
Author
|
I have changed it to trim the trailing line break as well to be more conformant to the dlerror() spec. |
dlerror() is supposed to return a char *, but currently returns a DWORD. Reimplement it using the Win32 FormatMessage function.
Author
|
Fixed a warning.. |
manojampalam
suggested changes
Mar 26, 2019
manojampalam
approved these changes
May 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dlerror() is supposed to return a char *, but currently returns a DWORD. Reimplement it using the Win32 FormatMessage function.
The only place dlerror() is used is ssh-pkcs11.c, which is not currently compiled into the Windows version. However, PR #331 enables PKCS#11 support, so if that PR is merged then this one should be also.