Use AllocConsole before initializing CLR to ensure codepage is correct#70
Merged
adityapatwardhan merged 1 commit intoPowerShell:masterfrom May 17, 2021
Merged
Conversation
Contributor
JamesWTruher
left a comment
There was a problem hiding this comment.
we should probably emit something if the AllocConsole fails. Can we log?
Member
Author
|
@JamesWTruher per the documentation, |
PaulHigin
approved these changes
May 17, 2021
Member
Author
|
I manually verified the |
adityapatwardhan
approved these changes
May 17, 2021
andyleejordan
approved these changes
May 17, 2021
Member
Author
|
@andschwa the code page behavior is actually in .NET and is only documented in their source code |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix PowerShell/PowerShell#15128
Because PowerShell launched from pwrshplugin.dll via WinRM doesn't have a console attached, the console codepage is not setup correctly due to how .NET works. This means that ANSI/Unicode characters are incorrectly represented. Manually validated using
treecommand and this encoded command: