Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: PowerShell/PowerShell-Native
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v7.4.0-preview.1
Choose a base ref
...
head repository: PowerShell/PowerShell-Native
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v7.4.0-preview.2
Choose a head ref
  • 4 commits
  • 4 files changed
  • 4 contributors

Commits on Jan 4, 2023

  1. Configuration menu
    Copy the full SHA
    b653177 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2023

  1. libpsl-native: Fix _FORTIFY_SOURCE macros (#88)

    This commit fixes the mistake in the `_FORTIFY_SOURCE` macro where it was not prefixed with underscore while it has to be (see e.g. https://github.com/search?q=repo%3Abminor%2Fglibc%20FORTIFY_SOURCE&type=code).
    
    Additionally, to make this macro add extra security, one has to enable optimizations. I am not sure if the build system enables them, but it is worth double checking that as well.
    
    Overall, I would recommend using `-D_FORTIFY_SOURCE=3` with  `-O2` or `-O3`. (The fortify source level 3 was added recently and you can read more about it here: https://developers.redhat.com/blog/2021/04/16/broadening-compiler-checks-for-buffer-overflows-in-_fortify_source).
    
    Remove superfluous `-O2` flag, since CMake adds `-O3` for `Release` builds anyway.
    
    Co-authored-by: Andy Jordan <andy.jordan@microsoft.com>
    disconnect3d and andyleejordan authored Jan 5, 2023
    Configuration menu
    Copy the full SHA
    af5359b View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2023

  1. Configuration menu
    Copy the full SHA
    64c2eb0 View commit details
    Browse the repository at this point in the history
  2. Fix manifest xml (#90)

    PaulHigin authored Jan 9, 2023
    Configuration menu
    Copy the full SHA
    30504b9 View commit details
    Browse the repository at this point in the history
Loading