PR Summary

Fix #6813

This regression was introduced by #6523, in PSModuleInfo.cs. A circular nested module check was removed because the comment there suggested it happens only with a deprecated workflow module. This causes a StackOverflow exception when running into circular nested modules.

Circular nested modules could happen for a module that is not well structured. For example, the module folder test contains two files: test.psd1 and test.psm1, and test.psd1 has the following content:

@{ ModuleVersion = '0.0.1'; RootModule = 'test'; NestedModules = @('test') }

The same value test is put in both RootModule and NestedModule, which will end up with a module whose nested module points to itself.

There are two changes in this PR:

1. Add back the circular nested module check in PSModuleInfo.cs.
2. Remove a wrong Dbg.Assert in ModuleCmdletBase.cs and two checks before it.
   • For the assertion Dbg.Assert(newManifestInfo.SessionState == ss, when facing the example above, the nested module will first be loaded with a different session state, and then when trying to load the root module, the same loaded nested module will be reused for it. So 'newManifestInfo.SessionState' is not ss. The assersion will fail in that case.
   • For the two checks before the assersion, they are not needed anymore based on the comments there.

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Change is not breaking
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
• User-facing changes
  • Not Applicable
  • OR
  • User-facing Documentation needed
    • Issue filed - Issue link:
• Testing - New and feature
  • Not Applicable or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed
    • Add [feature] if the change is significant or affects feature tests