Use correct win32 console mode w/ external commands #2991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Don't merge yet - this doesn't seem to fix all the issues. |
mirichmo
reviewed
Jan 11, 2017
Member
There was a problem hiding this comment.
Shouldn't this be initialized to ConsoleControl.ConsoleModes.Unknown?
Contributor
Author
There was a problem hiding this comment.
For purely defensive purposes, I suppose, but it would be a logically useless assignment.
At startup, we need to save the current console mode before potentially enabling VT100 support. Then, when running an external command, we should use that initial console mode instead of whatever mode we changed it to. An application can't rely on the shell enabling VT100 because enabling by default can cause problems for some applications, therefore Windows applications must enable VT100 themselves.
Contributor
Author
|
This is good to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At startup, we need to save the current console mode before potentially
enabling VT100 support.
Then, when running an external command, we should use that initial
console mode instead of whatever mode we changed it to.
An application can't rely on the shell enabling VT100 because enabling
by default can cause problems for some applications, therefore
Windows applications must enable VT100 themselves.
Fixes #1177