@MartinGC94 Could you please review?

I think the remaining mystery is with Array parameter completion.

if you do Get-Verb -Verb "A it will complete to Get-Verb -Verb "Add". Single array strings work fine.

But if you have an array and you surround quotes on the next item it does not tab complete correctly e.g. Get-Verb -Verb "Add", "C completes using file paths Get-Verb -Verb "Add", ".\CHANGELOG\". I suspect it is going back to file path completion.

@MartinGC94 @iSazonov Wondering if you would know why this might be happening?

I suspect it is going back to file path completion.

Yes, I suggest postpone this to follow PR.

@ArmaanMcleod Now the PR contains too many unrelated changes (style, bug fixes, enhancements). Our guideline requires not mixing. I'd prefer to split the PR: first with bug fix, then style/refactoring with minimal changes in GetMatchingResults() for minimal completers, then enhancement GetMatchingResults(). Also we could update s_charactersRequiringQuotes with SearchValues.Create() in a PR.

It's a valid concern, as per your feedback I have reverted the changes.

I will create follow up PRs to address these separately:

• Quote escaping for special characters
• Bug fix with Completion Result type, I will need to see if this can be changed for the completers
• Issue with quote completion with arrays

@MartinGC94 Thank you again for your review, I will address these in a separate PR so this one is easy to review and get merged in. I would also like to get these tested as well which will be easier in a separate PR

With that said, @iSazonov are you ok with current changes as they stand to get this merged in?

@iSazonov Was there anything else you wanted me to address? I'd like to use this code to address #24873 as well.

Let me know if there are concerns or we need MSFT team to approve these changes as well 🙂. I don't have anything else to add since there is no regression being introduced with these changes.

Is there any specific reason for not making the new method public? Afaik, there's still no built-in way to correctly handle quoting in third-party completers, and this should mostly solve that problem, right?

Nevertheless, big 👍 for creating the method in the first place, having to handle quoting separately for each completer is really annoying. :)

Is there any specific reason for not making the new method public? Afaik, there's still no built-in way to correctly handle quoting in third-party completers, and this should mostly solve that problem, right?

Nevertheless, big 👍 for creating the method in the first place, having to handle quoting separately for each completer is really annoying. :)

@MatejKafka I guess for now it should probably remain internal until it is finalised. I do agree it makes things a lot easier for managing quoting.

There were some concerns around escaping which should probably be addressed before making this public. I also think the method argument itself probably needs to be tweaked for public use. Not sure how I feel making users use Func<string, string> toolTipMapping or IEnumerable 😄. Could probably make a public overload which makes these easier to pass in and use more powershell friendly types.

Happy for you to raise an issue and we can discuss way forward.

@iSazonov @MartinGC94 thoughts?

Happy for you to raise an issue and we can discuss way forward.

Right.