Skip to content

[release/v7.4] Add a way to use only NuGet feed sources #24542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TravisEz13 merged 1 commit into from
Nov 4, 2024
Merged

[release/v7.4] Add a way to use only NuGet feed sources #24542

TravisEz13 merged 1 commit into from
Nov 4, 2024

Conversation

@TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Nov 4, 2024

Backport #24528

This pull request includes updates to the build.psm1 file to add a new source option and various configuration files to update package source URLs. Additionally, there are improvements to the tools/findMissingNotices.ps1 script to handle missing registrations and version conversion.

Updates to build.psm1:

  • Added NuGetOnly to the ValidateSet for the $Source parameter in the Switch-PSNugetConfig function.
  • Updated the Switch-PSNugetConfig function to handle the new NuGetOnly source option.

Configuration updates:

  • Updated the package source URL in nuget.config to use the new PowerShell URL.
  • Updated the package source URL in src/Modules/nuget.config to use the new PowerShell URL.
  • Updated the package source URL in test/tools/Modules/nuget.config to use the new PowerShell URL.

Improvements to tools/findMissingNotices.ps1:

  • Added a check to ensure that the registration table does not already contain the component name before adding it.
  • Added a new ConvertTo-SemVer function to handle version conversion and edge cases.

@TravisEz13
Add a way to use only NuGet feed sources (PowerShell#24528)
f73fb0e 
* Update build.psm1

* update default feeds

* fix issue with cgmanifest having duplicate existing entries

* update pattern
@TravisEz13 TravisEz13 self-assigned this Nov 4, 2024
@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Nov 4, 2024
@TravisEz13
Copy link
Member Author

TravisEz13 commented Nov 4, 2024

Failures in container tests are because #24543 is not backported yet.

@TravisEz13
Copy link
Member Author

TravisEz13 commented Nov 4, 2024

Windows CI failure is new, but seems unrelated. Rerunning.

@TravisEz13 TravisEz13 merged commit 72f8c58 into PowerShell:release/v7.4 Nov 4, 2024
@TravisEz13 TravisEz13 deleted the backport-24528 branch November 4, 2024 21:38
@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-service bot commented Nov 4, 2024 •
edited by unfurl-links bot
Loading

📣 Hey @TravisEz13, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

@jshigetomi jshigetomi mentioned this pull request Jan 21, 2025
Merged
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

Assignees

@TravisEz13 TravisEz13

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@TravisEz13