Skip to content

[release/v7.2] Fixes to Azure Public feed usage#24403

Merged
TravisEz13 merged 2 commits intoPowerShell:release/v7.2from
TravisEz13:backport-24149-11
Oct 10, 2024
Merged

[release/v7.2] Fixes to Azure Public feed usage#24403
TravisEz13 merged 2 commits intoPowerShell:release/v7.2from
TravisEz13:backport-24149-11

Conversation

@TravisEz13
Copy link
Member

Backport #24149

This pull request includes various updates to the PowerShell pipeline configurations, primarily focusing on improving the build and restore processes, and enhancing the configuration management. The most important changes include the addition of new variables, reorganization of group references, and updates to the build.psm1 script to support new features.

Pipeline Configuration Updates:

Build Script Enhancements:

  • build.psm1: Added support for ENABLE_MSBUILD_BINLOGS in the Restore-PSPackage function, including logic to handle MSBuild binary logs during restore failures. [1] [2]
  • build.psm1: Updated Switch-PSNugetConfig function to include mandatory parameters UserName and ClearTextPAT for private sources, and added Clear-PipelineNugetAuthentication and Set-PipelineNugetAuthentication calls.

These changes aim to streamline the build process, improve configuration management, and enhance logging and diagnostic capabilities.

* Fix code PATs

* Fix feed PATs

* remove gallery commit

* update feed url

* Update to new variable groups

* Fix Variable name

* Fix credential template

* Disable Signing setup in prep stage

* Capture nuget source list

* lock down the firewall

* Add creds to feed switch to allow single switch location

* Use switch from build.psm1

* Use switch template instead of commands

* update to test feed

* disable codeql in jobs where we don't compile

* disable code sign validation for prep

* move capture steps to restore phase to see if it speeds things up

* remove duplicate capture of nuget config

* update test service

* Only build windows test service on windows

* warn when no config is generated

* try to fix test service

* fix web listener refs

* try removing dotnet tool

* update feedname with user info

* update package version that is not found

* try moving failing jobs to restore phase

* allow nuget inset in either phase

* update package ref

* use the right reporoot

* Move everything to restore

* Try adding build phase

* put nuget files in the right place

* move bootstrap into yaml

* remove onebranch agent items from macos build

* switch to environment variable

* bump a couple of packages

* fix formatting

* Fix static analysis issue

* update feed url to test restoring everything

* install the AzFeed cred provider

* fix binlog issues
@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Oct 8, 2024
nuget.config Outdated
<packageSources>
<clear />
<add key="powershell" value="https://pkgs.dev.azure.com/powershell/PowerShell/_packaging/powershell/nuget/v3/index.json" />
<add key="powershell" value="https://pkgs.dev.azure.com/powershell/PowerShell/_packaging/powershell-dotnet-9/nuget/v3/index.json" />
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use the normal feed

Copy link
Member Author

@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TravisEz13 TravisEz13 merged commit 244fdca into PowerShell:release/v7.2 Oct 10, 2024
@TravisEz13 TravisEz13 deleted the backport-24149-11 branch October 10, 2024 19:29
@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-service bot commented Oct 10, 2024

📣 Hey @TravisEz13, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants