Skip to content

[release/v7.2] chore: Refactor Nuget package source creation to use New-NugetPackageSource function#24397

Merged
TravisEz13 merged 1 commit intoPowerShell:release/v7.2from
TravisEz13:backport-24104-0
Oct 8, 2024
Merged

[release/v7.2] chore: Refactor Nuget package source creation to use New-NugetPackageSource function#24397
TravisEz13 merged 1 commit intoPowerShell:release/v7.2from
TravisEz13:backport-24104-0

Conversation

@TravisEz13
Copy link
Member

Backport #24104

This pull request includes changes to improve the handling of NuGet package sources in the pipeline configuration and build scripts. The modifications introduce a new NugetPackageSource class and simplify the creation of NuGet configuration files.

Improvements to NuGet package handling:

  • .pipelines/templates/insert-nuget-config-azfeed.yml: Replaced direct usage of New-NugetConfigFile with a new New-NugetPackageSource function to create a NugetPackageSource object before passing it to New-NugetConfigFile. [1] [2]
  • build.psm1: Introduced a new NugetPackageSource class and the New-NugetPackageSource function to encapsulate NuGet package source details, and updated the New-NugetConfigFile function to accept a NugetPackageSource object.

Copy link
Member Author

@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Oct 8, 2024
@TravisEz13 TravisEz13 merged commit fc3f09b into PowerShell:release/v7.2 Oct 8, 2024
@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-service bot commented Oct 8, 2024

📣 Hey @TravisEz13, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants