Skip to content

Adding test coverage for Registry provider#2307

Merged
mirichmo merged 1 commit intoPowerShell:masterfrom
ChrisUbben:PortTestMultiMachineProvidersRegistry
Sep 23, 2016
Merged

Adding test coverage for Registry provider#2307
mirichmo merged 1 commit intoPowerShell:masterfrom
ChrisUbben:PortTestMultiMachineProvidersRegistry

Conversation

@ChrisUbben
Copy link
Copy Markdown

Could you both take a look at this for me? @Francisco-Gamino @JamesWTruher
Thanks!

@msftclas
Copy link
Copy Markdown

Hi @ChrisUbben, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Christopher Ubben). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@mirichmo mirichmo self-assigned this Sep 21, 2016
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should only run on Windows systems. Add
if(-not $IsWindows)
{
return
}
Before the Describe

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I talked to @JamesWTruher, he said that this is the more correct way of skipping all tests in a describe block:
#skip all tests on non-windows platform
$originalDefaultParameterValues = $PSDefaultParameterValues.Clone()
if ($IsWindows -eq $false) {
$PSDefaultParameterValues["it:skip"] = $true
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be redirected to $null as well

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks Mike!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants