Skip to content

Adding test coverage for PSDrive provider#2267

Merged
daxian-dbw merged 1 commit intoPowerShell:masterfrom
ChrisUbben:PortTestMultiMachineProvidersPSDrive
Sep 21, 2016
Merged

Adding test coverage for PSDrive provider#2267
daxian-dbw merged 1 commit intoPowerShell:masterfrom
ChrisUbben:PortTestMultiMachineProvidersPSDrive

Conversation

@ChrisUbben
Copy link
Copy Markdown

@ChrisUbben ChrisUbben commented Sep 14, 2016

Could you both take a look at this for me? @Francisco-Gamino @JamesWTruher
Thanks!

@msftclas
Copy link
Copy Markdown

msftclas commented Sep 14, 2016

Hi @ChrisUbben, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Christopher Ubben). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@daxian-dbw daxian-dbw self-assigned this Sep 14, 2016
@daxian-dbw
Copy link
Copy Markdown
Member

daxian-dbw commented Sep 14, 2016

Please fix the test failures in Travis CI.

@daxian-dbw
Copy link
Copy Markdown
Member

daxian-dbw commented Sep 16, 2016

test/powershell/Modules/Microsoft.PowerShell.Management/PSDrive.Tests.ps1

The test is about PSDrive, which doesn't belong to Microsoft.PowerShell.Management module. Please move the file to an appropriate folder.
@Francisco-Gamino could you please review this PR?

@ChrisUbben
Copy link
Copy Markdown
Author

ChrisUbben commented Sep 19, 2016

I talked to @JamesWTruher and he said to put these provider tests in Modules/Microsoft.PowerShell.Management/.

daxian-dbw
daxian-dbw requested changes Sep 21, 2016
View reviewed changes
test/powershell/Modules/Microsoft.PowerShell.Management/PSDrive.Tests.ps1 Outdated
Copy link
Copy Markdown
Member

@daxian-dbw daxian-dbw Sep 21, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove-PSDrive should be put in a finally block, so even if the above Should Be failed, the test drive can still be cleaned up. #closed

Copy link
Copy Markdown
Author

@ChrisUbben ChrisUbben Sep 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks Dongbo!

test/powershell/Modules/Microsoft.PowerShell.Management/PSDrive.Tests.ps1 Outdated
Copy link
Copy Markdown
Member

@daxian-dbw daxian-dbw Sep 21, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it should be $driveProp.PSDrive.Name | Should Be $psDriveName #closed

Copy link
Copy Markdown
Author

@ChrisUbben ChrisUbben Sep 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks Dongbo!

@daxian-dbw daxian-dbw merged commit 2b163f6 into PowerShell:master Sep 21, 2016
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
@TravisEz13 TravisEz13 added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Review - Waiting on Author labels May 27, 2020
@snyk-bot snyk-bot mentioned this pull request Aug 26, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Jun 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

Assignees

@daxian-dbw daxian-dbw

Labels

Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ChrisUbben @msftclas @daxian-dbw @TravisEz13