Skip to content

Revert "Replace win7 runtime with win8 and remove APISets (#18304)"#18322

Merged
adityapatwardhan merged 2 commits intoPowerShell:masterfrom
adityapatwardhan:manualRevert
Oct 18, 2022
Merged

Revert "Replace win7 runtime with win8 and remove APISets (#18304)"#18322
adityapatwardhan merged 2 commits intoPowerShell:masterfrom
adityapatwardhan:manualRevert

Conversation

@adityapatwardhan
Copy link
Copy Markdown
Member

@adityapatwardhan adityapatwardhan commented Oct 18, 2022

This reverts commit cc86f9f.

PR Summary

Reverts the change for runtime due to compliance issues.

PR Context

After this change Windows 7 is still broken due to removal of APISets. We will further investigate in 7.4.

PR Checklist

@pull-request-quantifier-deprecated
Copy link
Copy Markdown

This PR has 105 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Medium
Size       : +53 -52
Percentile : 41%

Total files changed: 20

Change summary by file extension:
.yml : +9 -9
.psm1 : +18 -18
.csproj : +7 -6
.ps1 : +19 -19

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@adityapatwardhan
Copy link
Copy Markdown
Member Author

/backport to v7.3.0-rc.1

@github-actions
Copy link
Copy Markdown
Contributor

@adityapatwardhan an error occurred while backporting to v7.3.0-rc.1, please check the run log for details!

The process '/usr/bin/git' failed with exit code 1

@adityapatwardhan
Copy link
Copy Markdown
Member Author

/backport to release/v7.3.0-rc.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.3.x-Done CL-NotInBuild Indicates that a PR is reverted and not part of the build. Medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants