Skip to content

[release/v7.2.7] Remove 1s minimum delay in Invoke-WebRequest for small files, and prevent file-download-error suppression.#18170

Merged
TravisEz13 merged 10 commits intorelease/v7.2.7from
backport/pr-17896-to-release/v7.2.7
Oct 13, 2022
Merged

[release/v7.2.7] Remove 1s minimum delay in Invoke-WebRequest for small files, and prevent file-download-error suppression.#18170
TravisEz13 merged 10 commits intorelease/v7.2.7from
backport/pr-17896-to-release/v7.2.7

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Backport of #17896 to release/v7.2.7

/cc @adityapatwardhan @AAATechGuy

Customer Impact

Testing

  • For any change that affects the release process, please work with a maintainer to come up with a plan to test this.

Risk

@pull-request-quantifier-deprecated
Copy link
Copy Markdown

This PR has 4 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +1 -3
Percentile : 1.6%

Total files changed: 1

Change summary by file extension:
.cs : +1 -3

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@ghost ghost assigned TravisEz13 Sep 27, 2022
@ghost ghost added the Review - Needed The PR is being reviewed label Oct 5, 2022
@ghost
Copy link
Copy Markdown

ghost commented Oct 5, 2022

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@TravisEz13
Copy link
Copy Markdown
Member

/azp run PowerShell-CI-macos

@ghost ghost removed the Review - Needed The PR is being reviewed label Oct 13, 2022
@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@TravisEz13 TravisEz13 merged commit 17d19d9 into release/v7.2.7 Oct 13, 2022
@TravisEz13 TravisEz13 deleted the backport/pr-17896-to-release/v7.2.7 branch October 13, 2022 18:29
@TravisEz13
Copy link
Copy Markdown
Member

/azp list

@ghost
Copy link
Copy Markdown

ghost commented Oct 20, 2022

🎉v7.2.7 has been released which incorporates this pull request.:tada:

Handy links:

@kasperk81
Copy link
Copy Markdown
Contributor

@TravisEz13 if Windows Server and Data Center 2025 are also going to ship with the old Windows PowerShell 5 and Windows PowerShell is stuck in time forever, can this be backported to v5? Having 45 times slower Invoke-WebRequest is unacceptable and the workaround $ProgressPreference = 'SilentlyContinue' is horribly unintuitive and tiring. We really hope that someone within Microsoft will realize this pain and that if there anything worth backporting to the suspended version of the product, this is it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants