Enable searching for assemblies in GAC_Arm64 on Windows#17816
Merged
iSazonov merged 8 commits intoPowerShell:masterfrom Aug 3, 2022
Merged
Enable searching for assemblies in GAC_Arm64 on Windows#17816iSazonov merged 8 commits intoPowerShell:masterfrom
iSazonov merged 8 commits intoPowerShell:masterfrom
Conversation
mcfi
approved these changes
Aug 2, 2022
iSazonov
reviewed
Aug 2, 2022
src/System.Management.Automation/CoreCLR/CorePsAssemblyLoadContext.cs
Outdated
Show resolved
Hide resolved
…text.cs Co-authored-by: Ilya <darpa@yandex.ru>
SteveL-MSFT
commented
Aug 2, 2022
src/System.Management.Automation/CoreCLR/CorePsAssemblyLoadContext.cs
Outdated
Show resolved
Hide resolved
SteveL-MSFT
commented
Aug 2, 2022
src/System.Management.Automation/CoreCLR/CorePsAssemblyLoadContext.cs
Outdated
Show resolved
Hide resolved
SteveL-MSFT
commented
Aug 2, 2022
src/System.Management.Automation/CoreCLR/CorePsAssemblyLoadContext.cs
Outdated
Show resolved
Hide resolved
SteveL-MSFT
commented
Aug 2, 2022
src/System.Management.Automation/CoreCLR/CorePsAssemblyLoadContext.cs
Outdated
Show resolved
Hide resolved
daxian-dbw
reviewed
Aug 2, 2022
src/System.Management.Automation/CoreCLR/CorePsAssemblyLoadContext.cs
Outdated
Show resolved
Hide resolved
other code cleanup since I'm making slightly bigger change
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
iSazonov
approved these changes
Aug 3, 2022
13 tasks
|
🎉 Handy links: |
5 tasks
Member
|
/backport to release/v7.2.7 |
1 task
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The code to enable searching the GAC was limited to GAC_32 and GAC_64 which fails on Windows Arm64 systems. Fix is to use GAC_Arm64 if pwsh is running as a Arm64 process.
Manually validated with PKI module with (requires admin):
PR Context
Fix #17814
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).