Skip to content

Enable searching for assemblies in GAC_Arm64 on Windows#17816

Merged
iSazonov merged 8 commits intoPowerShell:masterfrom
SteveL-MSFT:gac-arm64
Aug 3, 2022
Merged

Enable searching for assemblies in GAC_Arm64 on Windows#17816
iSazonov merged 8 commits intoPowerShell:masterfrom
SteveL-MSFT:gac-arm64

Conversation

@SteveL-MSFT
Copy link
Copy Markdown
Member

@SteveL-MSFT SteveL-MSFT commented Aug 1, 2022

PR Summary

The code to enable searching the GAC was limited to GAC_32 and GAC_64 which fails on Windows Arm64 systems. Fix is to use GAC_Arm64 if pwsh is running as a Arm64 process.

Manually validated with PKI module with (requires admin):

New-SelfSignedCertificate -DnsName "www.fabrikam.com", "www.contoso.com" -CertStoreLocation "cert:\LocalMachine\My"

PR Context

Fix #17814

PR Checklist

@SteveL-MSFT SteveL-MSFT requested a review from daxian-dbw August 2, 2022 00:13
…text.cs

Co-authored-by: Ilya <darpa@yandex.ru>
@pull-request-quantifier-deprecated
Copy link
Copy Markdown

This PR has 7 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +4 -3
Percentile : 2.8%

Total files changed: 1

Change summary by file extension:
.cs : +4 -3

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

Copy link
Copy Markdown
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daxian-dbw daxian-dbw added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Aug 2, 2022
@iSazonov iSazonov merged commit 51b2ac4 into PowerShell:master Aug 3, 2022
@ghost
Copy link
Copy Markdown

ghost commented Aug 12, 2022

🎉v7.3.0-preview.7 has been released which incorporates this pull request.:tada:

Handy links:

@adityapatwardhan
Copy link
Copy Markdown
Member

/backport to release/v7.2.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.2.x-Done CL-Engine Indicates that a PR should be marked as an engine change in the Change Log Extra Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Import-Module PKI fails with ARM64 powershell core 7.2.5 on ARM64 Windows 11 22H2

6 participants