Remove potential ANSI escape sequences in strings before using in Out-GridView#17664
Merged
daxian-dbw merged 3 commits intoPowerShell:masterfrom Jul 12, 2022
Merged
Remove potential ANSI escape sequences in strings before using in Out-GridView#17664daxian-dbw merged 3 commits intoPowerShell:masterfrom
Out-GridView#17664daxian-dbw merged 3 commits intoPowerShell:masterfrom
Conversation
iSazonov
reviewed
Jul 12, 2022
src/Microsoft.Management.UI.Internal/commandHelpers/OutGridView.cs
Outdated
Show resolved
Hide resolved
…w.cs Co-authored-by: Ilya <darpa@yandex.ru>
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
🎉 Handy links: |
5 tasks
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Out-GridViewspecifically uses the formatted output so that it resembles what you'd see inFormat-Table. This means that any ANSI that is included would be in the strings inOut-GridVieweven though WPF doesn't know how to render them.The fix is as objects are being sent to
Out-GridView, we use theStringDecoratedclass to remove known ANSI escape sequences so they are just plaintext.PR Context
Fix #17636
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).