Make AnsiRegex able to capture Hyperlink ansi sequences#17442
Make AnsiRegex able to capture Hyperlink ansi sequences#17442PaulHigin merged 3 commits intoPowerShell:masterfrom
AnsiRegex able to capture Hyperlink ansi sequences#17442Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
src/System.Management.Automation/FormatAndOutput/common/StringDecorated.cs
Show resolved
Hide resolved
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
SteveL-MSFT
left a comment
There was a problem hiding this comment.
Ok with this change given the other PR
|
🎉 Handy links: |
|
Confirmed that the original problem is newly fixed in 7.3 preview 5 - thanks everyone. |
PR Summary
Fix #16420
Make
AnsiRegexable to capture Hyperlink ansi sequences.With this fix, the repro
dir | ft @{n="link";e={$PSStyle.FormatHyperlink($_.name, ("some random text as a link" + "x" * (random -Max 5) ) )}}, lastwritetimeget the following outputPR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.