Skip to content

Base work for adding mariner amd64 package#17417

Merged
adityapatwardhan merged 1 commit intoPowerShell:release/v7.2.5from
TravisEz13:mariner-1-backport
May 24, 2022
Merged

Base work for adding mariner amd64 package#17417
adityapatwardhan merged 1 commit intoPowerShell:release/v7.2.5from
TravisEz13:mariner-1-backport

Conversation

@TravisEz13
Copy link
Copy Markdown
Member

@TravisEz13 TravisEz13 commented May 23, 2022

Backporting #17057

* add mariner package

* update signing

* update template branch

* Don't overwrite signed files

* use nevercopy

* update bom tests to support rpm

* switch to new output mode param

* more complex copy strategy

* change mariner distribution name

* Fix dependecies

* add error details

* fix variable name

* fix all distribution

* fix macos packaging error

* add diags

* fix macos

* fix package name validation

* check boms on ubuntu

* pend tests if rpm2cpio doesn't exist

* Revert "check boms on ubuntu"

This reverts commit e79cf86.

* use download task instead of azCopy

* Use ubuntu again

* filter symbol packages

* fix rpm test

* Get correct pshome

* skip hash check on

* Update tools/releaseBuild/azureDevOps/releaseBuild.yml
# Conflicts:
#	tools/packaging/packaging.psm1
@pull-request-quantifier-deprecated
Copy link
Copy Markdown

This PR has 240 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Large
Size       : +161 -79
Percentile : 64%

Total files changed: 7

Change summary by file extension:
.psm1 : +40 -10
.ps1 : +65 -38
.yml : +56 -31

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@TravisEz13 TravisEz13 changed the title Add mariner 1.0 amd64 package (#17057) Add mariner 1.0 amd64 package May 23, 2022
@TravisEz13

This comment was marked as outdated.

@azure-pipelines

This comment was marked as outdated.

@TravisEz13
Copy link
Copy Markdown
Member Author

/azp run PowerShell-Windows-Packaging-CI

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@TravisEz13 TravisEz13 changed the title Add mariner 1.0 amd64 package Base work for adding mariner amd64 package May 24, 2022
@TravisEz13
Copy link
Copy Markdown
Member Author

/remind me tomorrow

@github-actions
Copy link
Copy Markdown
Contributor

@TravisEz13 set a reminder for 5/25/2022

@adityapatwardhan adityapatwardhan merged commit 3cfa8eb into PowerShell:release/v7.2.5 May 24, 2022
@TravisEz13 TravisEz13 mentioned this pull request Jun 7, 2022
22 tasks
@adityapatwardhan adityapatwardhan added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jun 16, 2022
@ghost
Copy link
Copy Markdown

ghost commented Jun 21, 2022

🎉v7.2.5 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Large reminder

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants