Skip to content

Fixing dotnet sdk version parsing in build.psm1#17198

Merged
daxian-dbw merged 2 commits intoPowerShell:masterfrom
powercode:buildfix
Apr 29, 2022
Merged

Fixing dotnet sdk version parsing in build.psm1#17198
daxian-dbw merged 2 commits intoPowerShell:masterfrom
powercode:buildfix

Conversation

@powercode
Copy link
Copy Markdown
Collaborator

@powercode powercode commented Apr 26, 2022 •
edited
Loading

The current pattern incorrectly matches sdk versions on the form
6.0.300-preview.22204.3 [C:\program files\dotnet\sdk] as '6.0.300-preview.22204.3 '
including the space at the end, with cases the the semantic version constructor to throw a terminating error, halting the build.

Also improving error diagnostics for when this happens.

PR Summary

PR Context

PR Checklist

@ghost ghost assigned PaulHigin Apr 26, 2022
Fixing dotnet sdk version parsing in build.psm1
13034a6 
The current pattern incorrectly matches sdk versions on the form
6.0.300-preview.22204.3 [C:\program files\dotnet\sdk] as '6.0.300-preview.22204.3 '
including the space at the end, with cases the the semantic version constructor to throw a terminating error, halting the build.

Also improving error diagnostics for when this happens.
PaulHigin
PaulHigin approved these changes Apr 26, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@PaulHigin PaulHigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

iSazonov
iSazonov reviewed Apr 27, 2022
View reviewed changes
@daxian-dbw daxian-dbw mentioned this pull request Apr 27, 2022
Closed
22 tasks
@daxian-dbw @iSazonov
Update build.psm1
5726472 
Co-authored-by: Ilya <darpa@yandex.ru>
@pull-request-quantifier-deprecated
Copy link
Copy Markdown

pull-request-quantifier-deprecated bot commented Apr 28, 2022

This PR has 11 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +10 -1
Percentile : 4.4%

Total files changed: 1

Change summary by file extension:
.psm1 : +10 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@daxian-dbw daxian-dbw mentioned this pull request Apr 29, 2022
Closed
22 tasks
@daxian-dbw daxian-dbw merged commit edc489a into PowerShell:master Apr 29, 2022
@daxian-dbw daxian-dbw added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Apr 29, 2022
@daxian-dbw daxian-dbw assigned daxian-dbw and unassigned PaulHigin Apr 29, 2022
@powercode powercode deleted the buildfix branch May 2, 2022 10:50
@ghost
Copy link
Copy Markdown

ghost commented May 23, 2022

🎉v7.3.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@iSazonov iSazonov iSazonov approved these changes

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

+1 more reviewer

@PaulHigin PaulHigin PaulHigin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@daxian-dbw daxian-dbw

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@powercode @daxian-dbw @PaulHigin @iSazonov