Add type inference support for generic methods with type parameters#16951
Add type inference support for generic methods with type parameters#16951daxian-dbw merged 15 commits intoPowerShell:masterfrom
Conversation
|
Apparently the changes that got merged today made by code incompatible. I guess I should have tested it on the latest master before making this PR. |
Co-authored-by: Ilya <darpa@yandex.ru>
…artinGC94/PowerShell into TypeInferenceForGenericMethods
src/System.Management.Automation/engine/parser/TypeInferenceVisitor.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/parser/TypeInferenceVisitor.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Ilya <darpa@yandex.ru>
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
daxian-dbw
left a comment
There was a problem hiding this comment.
Sorry for the long delay in review. Looks good to me overall with 2 comments.
src/System.Management.Automation/engine/parser/TypeInferenceVisitor.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/parser/TypeInferenceVisitor.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/parser/TypeInferenceVisitor.cs
Outdated
Show resolved
Hide resolved
|
@MartinGC94 I refactored your change a little bit to avoid calling |
src/System.Management.Automation/engine/parser/TypeInferenceVisitor.cs
Outdated
Show resolved
Hide resolved
|
/rebase |
|
Started rebase: https://github.com/PowerShell/PowerShell/actions/runs/2387740157
|
|
@MartinGC94 The PR needs to be rebased to get rid of a test failure, but we are not able to force push to your branch. Can you please rebase the |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
🎉 Handy links: |
PR Summary
Fixes #16934
Now you can tab complete based on the expected output from a method that is invoked with type parameters such as
[array]::Empty[int]().<Tab>PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).