Fix $? to not be $false because native command wrote to stderr#13395
Merged
daxian-dbw merged 1 commit intoPowerShell:masterfrom Aug 19, 2020
Merged
Fix $? to not be $false because native command wrote to stderr#13395daxian-dbw merged 1 commit intoPowerShell:masterfrom
$? to not be $false because native command wrote to stderr#13395daxian-dbw merged 1 commit intoPowerShell:masterfrom
Conversation
iSazonov
approved these changes
Aug 11, 2020
daxian-dbw
approved these changes
Aug 11, 2020
Member
|
@PoshChan Please remind me in 12 hours |
Collaborator
|
@TravisEz13, this is the reminder you requested 12 hours ago |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
As @PowerShell/powershell-committee had agreed that a native command writing to
stderris not an indicator of failure, it doesn't make sense to have$?to$falseunless the native command also has a non-zero exit code. Fix is to move the setting of pipeline failure to the block only if the error record is not from a native command.This is an addition to Experimental Feature
PSNotApplyErrorActionToStderr.PR Context
Fix #13393
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.PSNotApplyErrorActionToStderr$ErrorActionPreferencedoesn't affect stderr output for native commands MicrosoftDocs/PowerShell-Docs#6466