Skip to content

Revert "Update formatter to not write newlines if content is empty (#11193)"#11342

Merged
iSazonov merged 1 commit intoPowerShell:masterfrom
iSazonov:revert-formatter-null
Dec 17, 2019
Merged

Revert "Update formatter to not write newlines if content is empty (#11193)"#11342
iSazonov merged 1 commit intoPowerShell:masterfrom
iSazonov:revert-formatter-null

Conversation

@iSazonov
Copy link
Copy Markdown
Collaborator

@iSazonov iSazonov commented Dec 14, 2019 •
edited
Loading

PR Summary

This reverts commit 51d2523. (#11193)

PR Context

Fix #11340

It seems we filter out a null too late.
We need to have more info about a scenario we tried to fix in #11193.

PR Checklist

@iSazonov iSazonov added the CL-NotInBuild Indicates that a PR is reverted and not part of the build. label Dec 14, 2019
@iSazonov iSazonov self-assigned this Dec 14, 2019
@iSazonov iSazonov added this to the 7.1.0-preview.1 milestone Dec 14, 2019
@SteveL-MSFT
Copy link
Copy Markdown
Member

SteveL-MSFT commented Dec 17, 2019

Should we add a test for the Get-Help scenario?

@iSazonov
Copy link
Copy Markdown
Collaborator Author

iSazonov commented Dec 17, 2019

Should we add a test for the Get-Help scenario?

The scenario is a side effect. If we change Get-Help we can lost the new test. I don't know how create more common and reliable test.

@SteveL-MSFT
Copy link
Copy Markdown
Member

SteveL-MSFT commented Dec 17, 2019

@iSazonov not suggesting we change Get-Help itself, but a test for (Get-Help Out-Null).Examples

@iSazonov
Copy link
Copy Markdown
Collaborator Author

iSazonov commented Dec 17, 2019

I will pull the test in follow PR (revert PR is not right place).

@iSazonov iSazonov merged commit dfb5b04 into PowerShell:master Dec 17, 2019
@iSazonov iSazonov deleted the revert-formatter-null branch December 17, 2019 19:53
@iSazonov iSazonov mentioned this pull request Dec 18, 2019
Merged
14 tasks
@daxian-dbw
Copy link
Copy Markdown
Member

daxian-dbw commented Mar 25, 2020

@iSazonov @SteveL-MSFT Since #11193 was reverted, is there an issue opened to track the original problem that PR was trying to fix?

@iSazonov
Copy link
Copy Markdown
Collaborator Author

iSazonov commented Mar 26, 2020

@daxian-dbw Original issue was discovered by @SteveL-MSFT but not registered so we haven't tracking issue. I do not know whether it is important for @SteveL-MSFT.

@ghost
Copy link
Copy Markdown

ghost commented Mar 26, 2020

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Mar 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

+1 more reviewer

@PoshChan PoshChan PoshChan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@iSazonov iSazonov

Labels

CL-NotInBuild Indicates that a PR is reverted and not part of the build.

Projects

None yet

Milestone

7.1.0-preview.1

Development

Successfully merging this pull request may close these issues.

Get-Help does not display whole example body

5 participants

@iSazonov @SteveL-MSFT @daxian-dbw @PoshChan @adityapatwardhan