Skip to content

Commit ca15ea7

Browse files
author
Patrick Meinecke
committed
Merged PR 30719: Add allowPartiallySucceededBuilds parameter for DownloadPipelineArtifact task
Otherwise we end up treating warnings like failures as this step will then always fail.
1 parent e716dad commit ca15ea7

15 files changed

+45
-1
lines changed

‎.pipelines/templates/linux.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,7 @@ jobs:
169169
inputs:
170170
artifact: drop_linux_build_${{ parameters.JobName }}
171171
path: $(Pipeline.Workspace)/drop_linux_build
172+
allowPartiallySucceededBuilds: true
172173
displayName: Download build
173174

174175
- pwsh: |

‎.pipelines/templates/mac.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,7 @@ jobs:
112112
inputs:
113113
artifact: 'macosBinResults-$(BuildArchitecture)'
114114
path: '$(Pipeline.Workspace)\Symbols'
115+
allowPartiallySucceededBuilds: true
115116
displayName: Download build
116117

117118
- pwsh: |

‎tools/releaseBuild/azureDevOps/releasePipeline.yml‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -214,6 +214,7 @@ stages:
214214
runBranch: '$(Build.SourceBranch)'
215215
artifact: metadata
216216
path: '$(Pipeline.Workspace)/releasePipeline/metadata'
217+
allowPartiallySucceededBuilds: true
217218

218219
- pwsh: |
219220
Get-ChildItem -Path $(Build.SourcesDirectory)
@@ -258,6 +259,7 @@ stages:
258259
runBranch: '$(Build.SourceBranch)'
259260
artifact: metadata
260261
path: '$(Pipeline.Workspace)/releasePipeline/metadata'
262+
allowPartiallySucceededBuilds: true
261263

262264
- pwsh: |
263265
Import-Module $(Build.SourcesDirectory)\ReleaseTools\AzDO -Force
@@ -469,6 +471,7 @@ stages:
469471
runBranch: '$(Build.SourceBranch)'
470472
artifact: metadata
471473
path: '$(Pipeline.Workspace)/releasePipeline/metadata'
474+
allowPartiallySucceededBuilds: true
472475
- pwsh: |
473476
Import-Module $(Build.SourcesDirectory)\ReleaseTools\AzDO -Force
474477
Set-AzDoProjectInfo -ProjectOwner PowerShell-Rel -ProjectName PowerShell
@@ -510,6 +513,7 @@ stages:
510513
runBranch: '$(Build.SourceBranch)'
511514
artifact: metadata
512515
path: '$(Pipeline.Workspace)/releasePipeline/metadata'
516+
allowPartiallySucceededBuilds: true
513517
- pwsh: |
514518
Import-Module $(Build.SourcesDirectory)\ReleaseTools\AzDO -Force
515519
Set-AzDoProjectInfo -ProjectOwner PowerShell-Rel -ProjectName PowerShell
@@ -613,6 +617,7 @@ stages:
613617
runBranch: '$(Build.SourceBranch)'
614618
artifact: metadata
615619
path: '$(Pipeline.Workspace)/releasePipeline/metadata'
620+
allowPartiallySucceededBuilds: true
616621

617622
- pwsh: |
618623
Import-Module $(Build.SourcesDirectory)\ReleaseTools\AzDO -Force

‎tools/releaseBuild/azureDevOps/templates/linux-authenticode-sign.yml‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,48 +22,56 @@ jobs:
2222
inputs:
2323
artifact: pwshLinuxBuild.tar.gz
2424
path: $(Build.ArtifactStagingDirectory)/linuxTars
25+
allowPartiallySucceededBuilds: true
2526
displayName: Download deb build
2627

2728
- task: DownloadPipelineArtifact@2
2829
inputs:
2930
artifact: pwshLinuxBuildMinSize.tar.gz
3031
path: $(Build.ArtifactStagingDirectory)/linuxTars
32+
allowPartiallySucceededBuilds: true
3133
displayName: Download min-size build
3234

3335
- task: DownloadPipelineArtifact@2
3436
inputs:
3537
artifact: pwshLinuxBuildArm32.tar.gz
3638
path: $(Build.ArtifactStagingDirectory)/linuxTars
39+
allowPartiallySucceededBuilds: true
3740
displayName: Download arm32 build
3841

3942
- task: DownloadPipelineArtifact@2
4043
inputs:
4144
artifact: pwshLinuxBuildArm64.tar.gz
4245
path: $(Build.ArtifactStagingDirectory)/linuxTars
46+
allowPartiallySucceededBuilds: true
4347
displayName: Download arm64 build
4448

4549
- task: DownloadPipelineArtifact@2
4650
inputs:
4751
artifact: pwshMarinerBuildAmd64.tar.gz
4852
path: $(Build.ArtifactStagingDirectory)/linuxTars
53+
allowPartiallySucceededBuilds: true
4954
displayName: Download mariner build
5055

5156
- task: DownloadPipelineArtifact@2
5257
inputs:
5358
artifact: pwshMarinerBuildArm64.tar.gz
5459
path: $(Build.ArtifactStagingDirectory)/linuxTars
60+
allowPartiallySucceededBuilds: true
5561
displayName: Download mariner arm64 build
5662

5763
- task: DownloadPipelineArtifact@2
5864
inputs:
5965
artifact: pwshLinuxBuildAlpine.tar.gz
6066
path: $(Build.ArtifactStagingDirectory)/linuxTars/pwshLinuxBuildAlpine.tar.gz
67+
allowPartiallySucceededBuilds: true
6168
displayName: Download alpine build
6269

6370
- task: DownloadPipelineArtifact@2
6471
inputs:
6572
artifact: pwshLinuxBuildFxdependent.tar.gz
6673
path: $(Build.ArtifactStagingDirectory)/linuxTars/pwshLinuxBuildFxdependent.tar.gz
74+
allowPartiallySucceededBuilds: true
6775
displayName: Download fxdependent build
6876

6977
- pwsh: |

‎tools/releaseBuild/azureDevOps/templates/linux-packaging.yml‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ jobs:
2626
artifact: authenticode-signed
2727
path: $(Build.ArtifactStagingDirectory)/pwshLinuxBuild-signed
2828
pattern: '**/pwshLinuxBuild.tar.gz'
29+
allowPartiallySucceededBuilds: true
2930
displayName: Download deb build
3031

3132
- ${{ if eq(variables.build,'deb') }} :
@@ -34,6 +35,7 @@ jobs:
3435
artifact: authenticode-signed
3536
path: $(Build.ArtifactStagingDirectory)/pwshLinuxBuildMinSize-signed
3637
pattern: '**/pwshLinuxBuildMinSize.tar.gz'
38+
allowPartiallySucceededBuilds: true
3739
displayName: Download min-size build
3840

3941
- ${{ if eq(variables.build,'deb') }} :
@@ -42,6 +44,7 @@ jobs:
4244
artifact: authenticode-signed
4345
path: $(Build.ArtifactStagingDirectory)/pwshLinuxBuildArm32-signed
4446
pattern: '**/pwshLinuxBuildArm32.tar.gz'
47+
allowPartiallySucceededBuilds: true
4548
displayName: Download arm32 build
4649

4750
- ${{ if eq(variables.build,'deb') }} :
@@ -50,6 +53,7 @@ jobs:
5053
artifact: authenticode-signed
5154
path: $(Build.ArtifactStagingDirectory)/pwshLinuxBuildArm64-signed
5255
pattern: '**/pwshLinuxBuildArm64.tar.gz'
56+
allowPartiallySucceededBuilds: true
5357
displayName: Download arm64 build
5458

5559
- ${{ if eq(variables.build,'rpm') }} :
@@ -58,6 +62,7 @@ jobs:
5862
artifact: authenticode-signed
5963
path: $(Build.ArtifactStagingDirectory)/pwshMarinerBuildAmd64-signed
6064
pattern: '**/pwshMarinerBuildAmd64.tar.gz'
65+
allowPartiallySucceededBuilds: true
6166
displayName: Download mariner amd64 build
6267

6368
- ${{ if eq(variables.build,'rpm') }} :
@@ -66,6 +71,7 @@ jobs:
6671
artifact: authenticode-signed
6772
path: $(Build.ArtifactStagingDirectory)/pwshMarinerBuildArm64-signed
6873
pattern: '**/pwshMarinerBuildArm64.tar.gz'
74+
allowPartiallySucceededBuilds: true
6975
displayName: Download mariner arm64 build
7076

7177
- ${{ if eq(variables.build,'alpine') }} :
@@ -74,6 +80,7 @@ jobs:
7480
artifact: authenticode-signed
7581
path: $(Build.ArtifactStagingDirectory)/pwshLinuxBuildAlpine-signed
7682
pattern: '**/pwshLinuxBuildAlpine.tar.gz'
83+
allowPartiallySucceededBuilds: true
7784
displayName: Download alpine build
7885

7986
- ${{ if eq(variables.build,'fxdependent') }} :
@@ -82,62 +89,71 @@ jobs:
8289
artifact: authenticode-signed
8390
path: $(Build.ArtifactStagingDirectory)/pwshLinuxBuildFxdependent-signed
8491
pattern: '**/pwshLinuxBuildFxdependent.tar.gz'
92+
allowPartiallySucceededBuilds: true
8593
displayName: Download fxdependent build
8694

8795
- ${{ if or(eq(variables.build,'deb'), eq(variables.build,'rpm')) }} :
8896
- task: DownloadPipelineArtifact@2
8997
inputs:
9098
artifact: pwshLinuxBuild-meta
9199
path: $(Build.ArtifactStagingDirectory)/pwshLinuxBuild-meta
100+
allowPartiallySucceededBuilds: true
92101
displayName: Download deb build meta
93102

94103
- ${{ if eq(variables.build,'deb') }} :
95104
- task: DownloadPipelineArtifact@2
96105
inputs:
97106
artifact: pwshLinuxBuildMinSize-meta
98107
path: $(Build.ArtifactStagingDirectory)/pwshLinuxBuildMinSize-meta
108+
allowPartiallySucceededBuilds: true
99109
displayName: Download min-size build meta
100110

101111
- ${{ if eq(variables.build,'deb') }} :
102112
- task: DownloadPipelineArtifact@2
103113
inputs:
104114
artifact: pwshLinuxBuildArm32-meta
105115
path: $(Build.ArtifactStagingDirectory)/pwshLinuxBuildArm32-meta
116+
allowPartiallySucceededBuilds: true
106117
displayName: Download arm32 build meta
107118

108119
- ${{ if eq(variables.build,'deb') }} :
109120
- task: DownloadPipelineArtifact@2
110121
inputs:
111122
artifact: pwshLinuxBuildArm64-meta
112123
path: $(Build.ArtifactStagingDirectory)/pwshLinuxBuildArm64-meta
124+
allowPartiallySucceededBuilds: true
113125
displayName: Download arm64 build meta
114126

115127
- ${{ if eq(variables.build,'rpm') }} :
116128
- task: DownloadPipelineArtifact@2
117129
inputs:
118130
artifact: pwshMarinerBuildAmd64-meta
119131
path: $(Build.ArtifactStagingDirectory)/pwshMarinerBuildAmd64-meta
132+
allowPartiallySucceededBuilds: true
120133
displayName: Download mariner x64 build meta
121134

122135
- ${{ if eq(variables.build,'rpm') }} :
123136
- task: DownloadPipelineArtifact@2
124137
inputs:
125138
artifact: pwshMarinerBuildArm64-meta
126139
path: $(Build.ArtifactStagingDirectory)/pwshMarinerBuildArm64-meta
140+
allowPartiallySucceededBuilds: true
127141
displayName: Download mariner arm64 build meta
128142

129143
- ${{ if eq(variables.build,'alpine') }} :
130144
- task: DownloadPipelineArtifact@2
131145
inputs:
132146
artifact: pwshLinuxBuildAlpine-meta
133147
path: $(Build.ArtifactStagingDirectory)/pwshLinuxBuild-meta
148+
allowPartiallySucceededBuilds: true
134149
displayName: Download alpine build meta
135150

136151
- ${{ if eq(variables.build,'fxdependent') }} :
137152
- task: DownloadPipelineArtifact@2
138153
inputs:
139154
artifact: pwshLinuxBuildFxdependent-meta
140155
path: $(Build.ArtifactStagingDirectory)/pwshLinuxBuild-meta
156+
allowPartiallySucceededBuilds: true
141157
displayName: Download fxdependent build meta
142158

143159
- pwsh: |

‎tools/releaseBuild/azureDevOps/templates/release-BuildJson.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ steps:
1212
runBranch: '$(Build.SourceBranch)'
1313
artifact: BuildInfoJson
1414
path: '$(Pipeline.Workspace)/releasePipeline/BuildInfoJson'
15+
allowPartiallySucceededBuilds: true
1516

1617
- pwsh: |
1718
Import-Module '$(Build.SourcesDirectory)/tools/ci.psm1'

‎tools/releaseBuild/azureDevOps/templates/release-GlobalToolTest.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ jobs:
2727
artifact: finalResults
2828
patterns: '**/*.nupkg'
2929
path: '$(Pipeline.Workspace)/releasePipeline/finalResults'
30+
allowPartiallySucceededBuilds: true
3031

3132
- pwsh: |
3233
$dotnetMetadataPath = "$(Build.SourcesDirectory)/DotnetRuntimeMetadata.json"

‎tools/releaseBuild/azureDevOps/templates/release-MsixBundle.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ jobs:
2525
artifact: finalResults
2626
patterns: '**/*.msix'
2727
path: '$(Pipeline.Workspace)\releasePipeline\msix'
28+
allowPartiallySucceededBuilds: true
2829

2930
- pwsh: |
3031
$cmd = Get-Command makeappx.exe -ErrorAction Ignore

‎tools/releaseBuild/azureDevOps/templates/release-PublishSymbols.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ steps:
1212
itemPattern: |
1313
**/*
1414
!**/*signed.zip
15+
allowPartiallySucceededBuilds: true
1516

1617
- pwsh: |
1718
Write-Verbose -Verbose "Enumerating $(Pipeline.Workspace)\results"

‎tools/releaseBuild/azureDevOps/templates/release-ReleaseToNuGet.yml‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ parameters:
22
- name: skipPublish
33
default: false
44
type: boolean
5-
5+
66
steps:
77
- task: DownloadPipelineArtifact@2
88
condition: and(eq('${{ parameters.skipPublish }}', 'false'), succeeded())
@@ -16,6 +16,7 @@ steps:
1616
artifact: finalResults
1717
patterns: '**/*.nupkg'
1818
path: '$(Pipeline.Workspace)/releasePipeline/finalResults'
19+
allowPartiallySucceededBuilds: true
1920

2021
- task: DownloadPipelineArtifact@2
2122
condition: and(eq('${{ parameters.skipPublish }}', 'false'), succeeded())
@@ -28,6 +29,7 @@ steps:
2829
runBranch: '$(Build.SourceBranch)'
2930
artifact: metadata
3031
path: '$(Pipeline.Workspace)/releasePipeline/metadata'
32+
allowPartiallySucceededBuilds: true
3133

3234
- pwsh: |
3335
#Exclude all global tool packages. Their names start with 'PowerShell.'

0 commit comments

Comments
 (0)