Skip to content

Commit 6096b84

Browse files
committed
Improve test readability for Extension parameter
- Remove Path from TestCases as it's constant across all tests - Rename ExpectedResult to ExpectedChildPath for clarity - Build full path in test body using 'folder' directly Addresses review feedback from @iSazonov
1 parent b53cd39 commit 6096b84

File tree

1 file changed

+8
-13
lines changed

1 file changed

+8
-13
lines changed

test/powershell/Modules/Microsoft.PowerShell.Management/Join-Path.Tests.ps1

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -87,43 +87,38 @@ Describe "Join-Path cmdlet tests" -Tags "CI" {
8787
It "should handle extension parameter: <TestName>" -TestCases @(
8888
@{
8989
TestName = "change extension"
90-
Path = "folder"
9190
ChildPath = "file.txt"
9291
Extension = ".log"
93-
ExpectedResult = "folder${SepChar}file.log"
92+
ExpectedChildPath = "file.log"
9493
}
9594
@{
9695
TestName = "add extension to file without extension"
97-
Path = "folder"
9896
ChildPath = "file"
9997
Extension = ".txt"
100-
ExpectedResult = "folder${SepChar}file.txt"
98+
ExpectedChildPath = "file.txt"
10199
}
102100
@{
103101
TestName = "extension without leading dot"
104-
Path = "folder"
105102
ChildPath = "file.txt"
106103
Extension = "log"
107-
ExpectedResult = "folder${SepChar}file.log"
104+
ExpectedChildPath = "file.log"
108105
}
109106
@{
110107
TestName = "double extension with dot"
111-
Path = "folder"
112108
ChildPath = "file.txt"
113109
Extension = ".tar.gz"
114-
ExpectedResult = "folder${SepChar}file.tar.gz"
110+
ExpectedChildPath = "file.tar.gz"
115111
}
116112
@{
117113
TestName = "double extension without dot"
118-
Path = "folder"
119114
ChildPath = "file.txt"
120115
Extension = "tar.gz"
121-
ExpectedResult = "folder${SepChar}file.tar.gz"
116+
ExpectedChildPath = "file.tar.gz"
122117
}
123118
) {
124-
param($TestName, $Path, $ChildPath, $Extension, $ExpectedResult)
125-
$result = Join-Path -Path $Path -ChildPath $ChildPath -Extension $Extension
126-
$result | Should -BeExactly $ExpectedResult
119+
param($TestName, $ChildPath, $Extension, $ExpectedChildPath)
120+
$result = Join-Path -Path "folder" -ChildPath $ChildPath -Extension $Extension
121+
$result | Should -BeExactly "folder${SepChar}${ExpectedChildPath}"
127122
}
128123
It "should remove extension when empty string is specified" {
129124
$result = Join-Path -Path "folder" -ChildPath "file.txt" -Extension ""

0 commit comments

Comments
 (0)