Skip to content

Fix 1794 by handling if prerelease is supplied as boolean too#1843

Merged
alerickson merged 2 commits intoPowerShell:masterfrom
o-l-a-v:fix-1794-prerelease-in-required-resource
Oct 3, 2025
Merged

Fix 1794 by handling if prerelease is supplied as boolean too#1843
alerickson merged 2 commits intoPowerShell:masterfrom
o-l-a-v:fix-1794-prerelease-in-required-resource

Conversation

@o-l-a-v
Copy link
Contributor

@o-l-a-v o-l-a-v commented Jul 7, 2025 •
edited
Loading

PR Summary

Tested like so:

# Build
& '.\build.ps1' -Clean -Build -BuildFramework net472

# Import built DLL
Import-Module -Name '.out\Microsoft.PowerShell.PSResourceGet\Microsoft.PowerShell.PSResourceGet.dll'

# Test issue from #1794
$DebugPreference = 'Continue'; Install-PSResource -TrustRepository -RequiredResource @{
    'PrereleaseTest' = @{
        'repository' = 'PSGallery'
        'prerelease' = $true
        'Scope'      = 'CurrentUser'
    }
} -WhatIf

PR Context

PR Checklist

@o-l-a-v
Copy link
Contributor Author

o-l-a-v commented Jul 7, 2025 •
edited
Loading

Maybe a new test and test module should be added? Like the test module by Justin Grote:

Only Install-PSResource has these parameters though, ref:

Would be nice if Find-PSResource had them too.

@o-l-a-v o-l-a-v changed the title Applied workaround suggested by Copilot, thanks bot! And some other fixes Fix 1794 by handling if prerelease is supplied as boolean too Jul 7, 2025
@alerickson alerickson mentioned this pull request Jul 15, 2025
Closed
14 tasks
@alerickson
Copy link
Member

alerickson commented Jul 15, 2025

We have a test prerelease module here that can be used for tests: https://www.powershellgallery.com/packages/testmodule99/1.0.0-beta2

@alerickson
Copy link
Member

alerickson commented Jul 15, 2025

We have some RequiredResource tests here: https://github.com/PowerShell/PSResourceGet/blob/master/test/InstallPSResourceTests/InstallPSResourceV2Server.Tests.ps1 could you add one or modify an existing one so that it's also checking a prerelease version?

@o-l-a-v
Copy link
Contributor Author

o-l-a-v commented Aug 11, 2025

Sorry, I missed this comment or forgot it @alerickson.

I added a test for it now. 😊

@o-l-a-v
Copy link
Contributor Author

o-l-a-v commented Sep 19, 2025

@alerickson @anamnavi: This one is ready for merge AFAIK, would be good to have in the v1.2 release.

@alerickson alerickson merged commit 45d1c34 into PowerShell:master Oct 3, 2025
10 of 12 checks passed
@o-l-a-v o-l-a-v deleted the fix-1794-prerelease-in-required-resource branch October 3, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alerickson alerickson alerickson approved these changes

@anamnavi anamnavi Awaiting requested review from anamnavi anamnavi is a code owner

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan adityapatwardhan is a code owner

@SydneyhSmith SydneyhSmith Awaiting requested review from SydneyhSmith SydneyhSmith is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Install-PSResource -RequiredResourceFile ignores the prerelease key if set to $true in a psd1 file

2 participants

@o-l-a-v @alerickson