Merged
Conversation
This commit adds doc comments for (almost) every item in the public API. I attempted to interpret the behavior of the code as true to the original intention as possible, which may have been different than originally intended by the original developer, particularly in the case of the `disable` functions of the global client, which confusingly do not seem to actually disable the client if it has already been initialized.
Contributor
Author
|
cc @oliverb123 |
Contributor
Author
|
Hi @oliverb123 , just wanted to put this back on your plate. In #6 you indicated this repo would be more actively maintained, so I thought I'd send out a friendly ping since it's been a month since I opened this PR. Thank you for your time and attention! :D |
oliverb123
approved these changes
Jun 2, 2025
Contributor
|
Hey @RobbieMcKinstry, sorry this took so long to get back to, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds doc comments for (almost) every item in the public API. I attempted to interpret the behavior of the code as true to the original intention as possible, which may have been different than originally intended by the original developer, particularly in the case of the
disablefunctions of the global client, which confusingly do not seem to actually disable the client if it has already been initialized.