feat: added generic properties and bumped version to 0.2.0#1
Merged
fuziontech merged 4 commits intoPostHog:mainfrom Jun 25, 2022
Merged
feat: added generic properties and bumped version to 0.2.0#1fuziontech merged 4 commits intoPostHog:mainfrom
fuziontech merged 4 commits intoPostHog:mainfrom
Conversation
Contributor
Author
|
@fuziontech are you the maintainer of this repository? |
Member
|
Hey @christoshadjiaslanis - Not officially, but I'm happy to get this in. Looks good and tests pass. I'll get this in now. 🚢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created this PR as I need support for nested hierarchical data in the properties and not just string kv pairs.
I bumped the minor version since this breaks our first experimental API (fields are no longer public).
Hopefully we can get this merged ASAP and I'll push to crates.io because we need this dependency in the Synth project.