fix: allow multiple user messages in a row for google gemini#246
Merged
VisargD merged 2 commits intoPortkey-AI:mainfrom Mar 16, 2024
Merged
Conversation
meronogbai
commented
Mar 6, 2024
|
|
||
| // @NOTE: This takes care of the "Please ensure that multiturn requests alternate between user and model." | ||
| // error that occurs when we have multiple user messages in a row. | ||
| const shouldAppendEmptyModeChat = lastRole === 'user' && role === 'user' && !params.model?.includes('vision'); |
Contributor
Author
There was a problem hiding this comment.
Opting out in case of gemini-pro-vision because it doesn't support multiturn chat anyway.
Collaborator
|
Thank you so much for the PR, @meronogbai! This is amazing. Paging @VisargD who can check this |
Collaborator
|
Thanks for the PR @meronogbai . I will review and merge this PR today. |
Collaborator
|
LGTM. Closes #258 |
VisargD
approved these changes
Mar 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title:
Description: (optional)
Motivation: (optional)
How to test?
The following snippet breaks with gemini-pro even though it works with openai. Checkout this branch and everything should work without issues 🫡