Skip to content

Create example popup upon installation#908

Merged
fpcorso merged 4 commits intodevelopfrom
feature/857
Dec 1, 2020
Merged

Create example popup upon installation#908
fpcorso merged 4 commits intodevelopfrom
feature/857

Conversation

@fpcorso
Copy link
Copy Markdown
Contributor

@fpcorso fpcorso commented Nov 27, 2020

Description

Creates an example popup when the plugin is first installed.

Related Issue

Issue: #857

Types of changes

Creates a new popup when the plugin is installed and adds two new steps to the all popups page tour.

Screenshots

image

This has been tested in the following browsers

  • Chrome
  • Firefox
  • Edge
  • Safari

Checklist:

  • My code has been tested in the latest version of WordPress.
  • My code does not have any warnings from ESLint.
  • My code does not have any warnings from StyleLint.
  • My code does not have any warnings from PHPCS.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • All new functions and classes have code documentation.

Since I copied and pasted in the settings, the popup was being created
 with the cookie of pum-2094 without the number part being dynamically
  changed to match the actual example popup's ID.

Issue #857
Add a new step pointing to the enabled toggle and then another step
pointing out opens and conversions.

Issue #847
@fpcorso fpcorso linked an issue Nov 27, 2020 that may be closed by this pull request
@fpcorso fpcorso requested a review from danieliser November 27, 2020 18:56
@fpcorso
Copy link
Copy Markdown
Contributor Author

fpcorso commented Nov 27, 2020

@danieliser Thought we'd start with just one example popup to gauge interest and usage.

Copy link
Copy Markdown
Member

@danieliser danieliser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love that it attempts to send them to our site for each new user that goes to the example popup.

Should we have the last button on the initial set of pointers lead to editing the example popup so the tour can continue?

@fpcorso fpcorso merged commit bc0772c into develop Dec 1, 2020
@fpcorso fpcorso deleted the feature/857 branch December 1, 2020 17:20
@fpcorso
Copy link
Copy Markdown
Contributor Author

fpcorso commented Dec 1, 2020

@danieliser I had thought of that but they will see this screen after they create their first popup, if they follow our preferred path:

  1. Activate plugin
  2. See welcome screen with button to create first popup
  3. New popup screen with its tour
  4. Then, either their frontend so they see their new popup or the all popups page where they would finally see this.

@danieliser
Copy link
Copy Markdown
Member

@fpcorso will the example popup have a trigger that causes it to show for non admins right away? That might not be great, assuming that isn't what you meant by seeing it on front end.

@fpcorso
Copy link
Copy Markdown
Contributor Author

fpcorso commented Dec 1, 2020

@danieliser Ah, sorry. To clarify: I meant to see the popup they created, assuming they did so after the welcome screen. The example popup is disabled and would only show if the admin enabled it.

@danieliser
Copy link
Copy Markdown
Member

Sounds perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create example popup(s) upon install

2 participants