Skip to content

Adds customization to analytics route#890

Merged
fpcorso merged 7 commits intodevelopfrom
feature/783
Oct 21, 2020
Merged

Adds customization to analytics route#890
fpcorso merged 7 commits intodevelopfrom
feature/783

Conversation

@fpcorso
Copy link
Copy Markdown
Contributor

@fpcorso fpcorso commented Oct 20, 2020

Description

Allows the analytics endpoint to be customized.

Related Issue

Issue: #783

Types of changes

  1. When the bypass adblocker setting is enabled, randomize (or use custom string) for the route.
  2. Randomize (or use custom string) for namespace.

This has been tested in the following browsers

  • Chrome
  • Firefox
  • Edge
  • Safari

Checklist:

  • My code has been tested in the latest version of WordPress.
  • My code does not have any warnings from ESLint.
  • My code does not have any warnings from StyleLint.
  • My code does not have any warnings from PHPCS.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • All new functions and classes have code documentation.

@fpcorso fpcorso changed the title Adds customization to analytics route [WIP] Adds customization to analytics route Oct 20, 2020
@fpcorso fpcorso requested a review from danieliser October 20, 2020 14:25
@fpcorso fpcorso linked an issue Oct 20, 2020 that may be closed by this pull request
Copy link
Copy Markdown
Member

@danieliser danieliser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very solid choices on this one. Probably better than I would have done on first pass.

@fpcorso fpcorso merged commit d42cfac into develop Oct 21, 2020
@fpcorso fpcorso deleted the feature/783 branch October 21, 2020 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow customizing the analytics endpoint

2 participants