Form integration bug fixes and improvements#889
Merged
Conversation
fpcorso
commented
Oct 19, 2020
| args.popup.length && | ||
| args.popup.is($popup)) || | ||
| !settings.only_in_popup | ||
| ) { |
Contributor
Author
There was a problem hiding this comment.
Fixed spaces to tabs so it shows the whole file changed. The only actual code changes is this conditional.
Member
There was a problem hiding this comment.
PHPStorm doesn't allow line by line staging which is ashame, but VSCode does which is nice, you can highlight the changed lines, stage them, commit, then stage the rest of the file for a second commit.
…mine if we should process the submission Since we repeat the same code for getting the popup ID and for increasing the conversion in all integrations, we should also move that here in case we need to change how that works in the future. Issue #887
This was
linked to
issues
Oct 19, 2020
danieliser
approved these changes
Oct 19, 2020
Member
danieliser
left a comment
There was a problem hiding this comment.
Like the massive deduplication of code. Looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Collection of commits relating to fixing the bugs in the form integration system
Related Issue
Issues: #886, #887, #706
Types of changes
argsargument instead of using the passed form.This has been tested in the following browsers
Checklist: