Skip to content

Adds new periodical tips#888

Merged
fpcorso merged 9 commits intodevelopfrom
feature/834
Oct 19, 2020
Merged

Adds new periodical tips#888
fpcorso merged 9 commits intodevelopfrom
feature/834

Conversation

@fpcorso
Copy link
Copy Markdown
Contributor

@fpcorso fpcorso commented Oct 15, 2020

Description

Add a new system to randomly show helpful tips in the Popup Maker admin areas.

Related Issue

Issue: #834

Types of changes

  1. Adds new tip alerts that are randomly selected, once a month.

Screenshots

This has been tested in the following browsers

  • Chrome
  • Firefox
  • Edge
  • Safari

Checklist:

  • My code has been tested in the latest version of WordPress.
  • My code does not have any warnings from ESLint.
  • My code does not have any warnings from StyleLint.
  • My code does not have any warnings from PHPCS.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • All new functions and classes have code documentation.

@fpcorso fpcorso linked an issue Oct 15, 2020 that may be closed by this pull request
@fpcorso fpcorso changed the title Adds new periodical tips [WIP] Adds new periodical tips Oct 16, 2020
@fpcorso fpcorso requested a review from danieliser October 16, 2020 15:29
Copy link
Copy Markdown
Member

@danieliser danieliser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start, we can just layer on more conditional tips in the future.

Should we make some other things like the BuddyPress or WooCommerce notices part of this or should they stay separate mechanisms to be more explicitly seen?

@fpcorso fpcorso merged commit e352271 into develop Oct 19, 2020
@fpcorso fpcorso deleted the feature/834 branch October 19, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Periodical Tip/Suggestion Message

2 participants