Skip to content

Conversion Counters#885

Merged
fpcorso merged 13 commits intodevelopfrom
feature/775
Oct 19, 2020
Merged

Conversion Counters#885
fpcorso merged 13 commits intodevelopfrom
feature/775

Conversation

@fpcorso
Copy link
Copy Markdown
Contributor

@fpcorso fpcorso commented Oct 8, 2020 •
edited
Loading

Description

Adds basic conversion counters to popups to go with original open counters.

Related Issue

Closes #775

Types of changes

Adds:

  1. New columns on "All Popups" for conversions and conversion rate
  2. Adds conversion info to Analytics meta box on popup editor
  3. Adds an action to the form submission js to fire conversion increase to analytics endpoint
  4. Adds an increase to conversion counter in the PHP code when forms are submitted without AJAX

Screenshots

This has been tested in the following browsers

  • Chrome
  • Firefox
  • Edge
  • Safari

Checklist:

  • My code has been tested in the latest version of WordPress.
  • My code does not have any warnings from ESLint.
  • My code does not have any warnings from StyleLint.
  • My code does not have any warnings from PHPCS.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • All new functions and classes have code documentation.

@fpcorso fpcorso linked an issue Oct 9, 2020 that may be closed by this pull request
Implement basic conversion counters #775
Closed
5 tasks
fpcorso added 6 commits October 9, 2020 11:37
@fpcorso
Add conversion counter increase to PHP side of form integration
3965e98 
Issue #775
@fpcorso
Remove additional conditions that were added
d64f850 
Issue #775
@fpcorso
Remove conversion rate data when Popup Analytics is installed
c0b465f 
We already hide the opens and conversions when analytics is active as the extensions adds its own data to the columns. May change in the future version of the extension.

Issue #775
@fpcorso
Add conditional to bail early if conversion counter
0f5a803 
If the form submission has already been counted in the backend, we can skip firing the conversion beacon in the JS.

Issue #775
@fpcorso
Set the popup key within the formidable forms integration
2b8ddaa
@fpcorso
Use the args.popup key instead of form in our conversion beacon
3f8f019
@fpcorso fpcorso changed the title Conversion Counters [WIP] Conversion Counters Oct 14, 2020
@fpcorso fpcorso requested a review from danieliser October 14, 2020 14:53
danieliser
danieliser approved these changes Oct 15, 2020
View reviewed changes
Comment thread classes/Admin/Popups.php
@fpcorso fpcorso merged commit eb08aa2 into develop Oct 19, 2020
@fpcorso fpcorso deleted the feature/775 branch October 19, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danieliser danieliser danieliser approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement basic conversion counters

2 participants

@fpcorso @danieliser