Migrate to standard library type traits#3105
Merged
SergioRAgostinho merged 3 commits intoPointCloudLibrary:masterfrom May 31, 2019
Merged
Migrate to standard library type traits#3105SergioRAgostinho merged 3 commits intoPointCloudLibrary:masterfrom
SergioRAgostinho merged 3 commits intoPointCloudLibrary:masterfrom
Conversation
taketwo
reviewed
May 30, 2019
common/include/pcl/point_traits.h
Outdated
| template<typename T> struct decomposeArray | ||
| { | ||
| typedef typename boost::remove_all_extents<T>::type type; | ||
| typedef typename std::remove_all_extents<T>::type type; |
Member
There was a problem hiding this comment.
typedef std::remove_all_extents_t<T> type
| { | ||
| template<typename T> inline | ||
| typename boost::disable_if_c<boost::is_array<T>::value>::type | ||
| typename std::enable_if<!std::is_array<T>::value>::type |
Member
There was a problem hiding this comment.
std::enable_if_t<!std::is_array<T>::value>
And everywhere below
Member
|
LGTM, but since you started to use |
75c4327 to
6170a66
Compare
Member
Author
|
As usual, I'll squash commits per module and merge once the PR is accepted. |
taketwo
approved these changes
May 31, 2019
6170a66 to
978daeb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I performed all trivial replacement from type traits. There's still a lot being used from Boost.MPL, Boost.Preprocessor and Boost.Concept. Stripping those out is not feasible at this point.